Repository navigation
fix(ci): qualify locked test dependencies and declared style gate - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clean Python3.11 cloud matrix installed the locked test group, then required API/SSE tests could not collect because FastAPI/Starlette were absent. Select the already-declared locked search extra in both portable matrix setups and native Test workflow. Preserve the existing remote-client/Modal exclusions.
Correct stale API fixtures to match current source: health probes are public, successful protected search uses a synthetic test key, missing/wrong keys are tested on search, and unconfigured authentication has explicit503 coverage. Application auth behavior is unchanged.
The declared Style gate also exposed baseline formatting/lint debt. Apply pinned Ruff0.14.10 formatting and narrow lint fixes: explicit timeout exception chains, equivalent built-in TimeoutError, removal of unused assignment targets while preserving calls, and deferred config import after dotenv through importlib. No production credential access or feature redesign.
Validation: original missing-import failure reproduced; API/SSE18tests PASS bothPython3.11/3.12;194focused API/SSE+timeout/eventbus/emptyiteration/repltools tests PASS on3.11. Pinned Ruff lint/format PASS across all105files; formatting-only AST comparison and diff checks PASS. Full matrix, coverage and advisory ty remain with the coordinator's serialized cloud retry. No full suite, provider/settings change or production release ran locally.