Skip to content

Commit 03ff94c

Browse files
authored
Merge pull request #1789 from fsprojects/repo-assist/perf-html-parser-reuse-sb-2026-08-02-c5e1a26b4608f1a3
[repo-assist] perf: HtmlParser reuses CurrentTag and Content StringBuilders across tokens
2 parents 4d576fa + 34ea6bc commit 03ff94c

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎src/FSharp.Data.Html.Core/HtmlParser.fs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ module internal HtmlParser =
171171
member x.EmitSelfClosingTag() =
172172
let name = x.CurrentTag.ToString().Trim()
173173
let result = Tag(true, name, x.GetAttributes())
174-
x.CurrentTag <- { Contents = StringBuilder() }
174+
x.CurrentTag.Clear()
175175
x.InsertionMode <- DefaultMode
176176
x.Attributes <- []
177177
x.Tokens <- result :: x.Tokens
@@ -217,7 +217,7 @@ module internal HtmlParser =
217217
else
218218
DefaultMode
219219

220-
x.CurrentTag <- { Contents = StringBuilder() }
220+
x.CurrentTag.Clear()
221221
x.Attributes <- []
222222
x.Tokens <- result :: x.Tokens
223223

@@ -228,7 +228,7 @@ module internal HtmlParser =
228228
for c in content do
229229
x.ConsAttrValue c
230230

231-
x.Content <- { Contents = StringBuilder() }
231+
x.Content.Clear()
232232
x.InsertionMode <- DefaultMode
233233

234234
member x.Emit() : unit =
@@ -252,7 +252,7 @@ module internal HtmlParser =
252252
| DocTypeMode -> DocType content
253253
| CDATAMode -> CData(content.Replace("<![CDATA[", "").Replace("]]>", ""))
254254

255-
x.Content <- { Contents = StringBuilder() }
255+
x.Content.Clear()
256256
x.InsertionMode <- DefaultMode
257257

258258
match result with

0 commit comments

Comments
 (0)