Skip to content

Add cookieless config option for Matomo & make it default - #23374

Open
B0r1sD wants to merge 4 commits into
galaxyproject:devfrom
B0r1sD:matomo_cookieless
Open

Add cookieless config option for Matomo & make it default#23374
B0r1sD wants to merge 4 commits into
galaxyproject:devfrom
B0r1sD:matomo_cookieless

Conversation

@B0r1sD

@B0r1sD B0r1sD commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Closes #23322, details can be found in that issue.

Included a unit test as well.

Used Claude Opus 4.8 to help me integrate this in the Galaxy way and show me how I could test all the individual added changes.

How to test the changes?

(Select all options that apply)

  1. Test the unit test with:
.venv/bin/python -m pytest test/unit/webapps/test_js_app_template.py -v
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
  1. To test the Mako template: python -c "from mako.template import Template; Template(filename='templates/js-app.mako')"
  2. Generate the config option in galaxy.yml.sample, galaxy_options.rst and _galaxy_config_schema_attributes.py via config_manage.py:
python lib/galaxy/config/config_manage.py build_sample_yaml galaxy --add-comments
python lib/galaxy/config/config_manage.py build_rst galaxy > doc/source/admin/galaxy_options.rst 2>/dev/null
python lib/galaxy/config/config_manage.py build_config_types galaxy

and this was checked with make config-rebuild.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@B0r1sD

B0r1sD commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Ping @pauldg

@B0r1sD

B0r1sD commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Perhaps we should be more explicit in a cookiebanner being required whenever cookieless tracking is disabled in the description of the new config option (which is the opposite of the current proposed default). I'll leave that in the middle as I did not immediately find a good source on the related EU rules.

@B0r1sD

B0r1sD commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

All failed CI tests seem unrelated to the changes in this PR:

Caused by: Failed to fetch: `[https://wheels.galaxyproject.org/simple/fissix/`](https://wheels.galaxyproject.org/simple/fissix/%60)
  Caused by: HTTP status server error (503 Service Unavailable) for url (https://wheels.galaxyproject.org/simple/fissix/)
- Generated html report: file:///home/runner/work/galaxy/galaxy/galaxy%20root/run_integration_tests.html -
=========================== short test summary info ============================
FAILED test/integration_selenium/test_objectstore_selection.py::TestMultipleQuotasSeleniumIntegration::test_multiple_quota_sources_for_user - selenium.common.exceptions.TimeoutException: Message: Timeout waiting for history da92407cb46a61f3 to have hid 2 - have hids [1]
====== 1 failed, 58 passed, 5 skipped, 44 warnings in 1924.20s (0:32:04) =======
Testing complete. HTML report is in "./run_integration_tests.html".
FAILED lib/galaxy_test/selenium/test_galaxyai.py::TestGalaxyAI::test_delete_chats_via_selection - playwright._impl._errors.TimeoutError: Timeout waiting on CSS selector [.system-notice] to become visible.
====== 1 failed, 86 passed, 65 skipped, 22 warnings in 1884.01s (0:31:24) ======
Testing complete. HTML report is in "./run_playwright_tests.html".
=========================== short test summary info ============================
FAILED lib/galaxy_test/selenium/test_histories_published.py::TestPublishedHistories::test_published_histories_tag_click - selenium.common.exceptions.NoSuchElementException: Message: no such element: Unable to locate element: {"method":"css selector","selector":".tag"}
  (Session info: chrome=151.0.7922.13

@B0r1sD
B0r1sD marked this pull request as ready for review August 28, 2026 08:02
@github-actions github-actions Bot added this to the 26.2 milestone Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

Cookieless Matomo integration

1 participant