Add cookieless config option for Matomo & make it default - #23374
Open
B0r1sD wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
Ping @pauldg |
Contributor
Author
|
Perhaps we should be more explicit in a cookiebanner being required whenever cookieless tracking is disabled in the description of the new config option (which is the opposite of the current proposed default). I'll leave that in the middle as I did not immediately find a good source on the related EU rules. |
Contributor
Author
|
All failed CI tests seem unrelated to the changes in this PR: Caused by: Failed to fetch: `[https://wheels.galaxyproject.org/simple/fissix/`](https://wheels.galaxyproject.org/simple/fissix/%60)
Caused by: HTTP status server error (503 Service Unavailable) for url (https://wheels.galaxyproject.org/simple/fissix/)- Generated html report: file:///home/runner/work/galaxy/galaxy/galaxy%20root/run_integration_tests.html -
=========================== short test summary info ============================
FAILED test/integration_selenium/test_objectstore_selection.py::TestMultipleQuotasSeleniumIntegration::test_multiple_quota_sources_for_user - selenium.common.exceptions.TimeoutException: Message: Timeout waiting for history da92407cb46a61f3 to have hid 2 - have hids [1]
====== 1 failed, 58 passed, 5 skipped, 44 warnings in 1924.20s (0:32:04) =======
Testing complete. HTML report is in "./run_integration_tests.html".
FAILED lib/galaxy_test/selenium/test_galaxyai.py::TestGalaxyAI::test_delete_chats_via_selection - playwright._impl._errors.TimeoutError: Timeout waiting on CSS selector [.system-notice] to become visible.
====== 1 failed, 86 passed, 65 skipped, 22 warnings in 1884.01s (0:31:24) ======
Testing complete. HTML report is in "./run_playwright_tests.html".
=========================== short test summary info ============================
FAILED lib/galaxy_test/selenium/test_histories_published.py::TestPublishedHistories::test_published_histories_tag_click - selenium.common.exceptions.NoSuchElementException: Message: no such element: Unable to locate element: {"method":"css selector","selector":".tag"}
(Session info: chrome=151.0.7922.13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23322, details can be found in that issue.
Included a unit test as well.
Used Claude Opus 4.8 to help me integrate this in the Galaxy way and show me how I could test all the individual added changes.
How to test the changes?
(Select all options that apply)
python -c "from mako.template import Template; Template(filename='templates/js-app.mako')"and this was checked with
make config-rebuild.License