Skip to content

[WIP] Test tool form against the tool request path - #23412

Draft
guerler wants to merge 49 commits into
galaxyproject:devfrom
guerler:selenium_tool_form.001
Draft

[WIP] Test tool form against the tool request path#23412
guerler wants to merge 49 commits into
galaxyproject:devfrom
guerler:selenium_tool_form.001

Conversation

@guerler

@guerler guerler commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Follow up for #23372, requires: #23414, xref: #23329

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 26.2 milestone Aug 30, 2026
@guerler
guerler force-pushed the selenium_tool_form.001 branch 3 times, most recently from 14d6122 to 3e3ca76 Compare September 1, 2026 06:52
@guerler guerler mentioned this pull request Sep 1, 2026
Merged
4 tasks
@guerler
guerler force-pushed the selenium_tool_form.001 branch 2 times, most recently from 1e3c0b7 to 989002e Compare September 1, 2026 14:10
guerler added 21 commits September 2, 2026 14:15
@guerler
Resolve a conditional boolean test value the way the tool loader does
073c8a7
@guerler
Validate the two conditional boolean tools that now build a request
8a74f62
@guerler
Run the tool form harness against the tool request submission path
2962273
@guerler
Allow tool form tests to stop at submission and skip job execution
9470328
@guerler
Drive every framework tool test through the form without running the job
31a956c
@guerler
Run the tool form harness against the tool request submission path
99ec608
@guerler
Check the form's submitted tool state against the test case
19430e7
@guerler
List the form tests that cannot be driven yet, with the reason for each
fb98eaa
@guerler
Enable the tool request path for local runs of the form harness
be858c4
@guerler
Cover the tool form state comparison with unit tests
57d7c4c
@guerler
Compare repeat instances element by element rather than as text
34a3426
@guerler
Detect the tool request path from the recorded request, not browser t…
a17091e 
…imings
@guerler
Sort the imports the two new modules added
ff235d1
@guerler
Hold data parameters to the dataset the test case staged
8d9e2db
@guerler
Type the harness helpers mypy could not resolve
6a7b7fd
@guerler
Let a rejected submission stand for tests that declare invalid input
9f40327
@guerler
Insert repeat instances after the conditional that reveals them
7cc69b8
@guerler
Fill repeats, composites and colours the way the form expects them
3eea29e
@guerler
Open only the sections the form left closed
54e590b
@guerler
Clear a select before setting it and accept either the value or its l…
1958893 
…abel
@guerler
Pick the select option whose label matches exactly
7f0f855
guerler added 28 commits September 2, 2026 14:28
@guerler
Set data parameters before the ones that read options from them
3449f89
@guerler
Stage each copy of a repeated file and accept any of them
b7f5df0
@guerler
Carry dbkey and metadata into staging so validators see them
8b44e54
@guerler
Record why a mismatched datatype leaves the form with nothing to offer
017a06f
@guerler
Refresh the known failure reasons against what now happens
bd7d4fb
@guerler
Fail loudly when a select has no option for the declared value
f5f9a14
@guerler
Upload a test input declared as a directory as one
0341b52
@guerler
Say what the two nested conditional cases actually do
52b096d
@guerler
Move the comparison tests out of a packaged directory
188bb36
@guerler
Fill a repeat's datasets once its instances exist
8cd4224
@guerler
Treat equal numbers and equal multi-values as matching
f4cfadc
@guerler
Set a conditional selector before the parameters it re-renders
e230429
@guerler
Record that an unset optional data column blocks async submission
e3c6a40
@guerler
Give a multiple select a list default when one option is selected
ef6d21d
@guerler
Note the accessibility violation behind the last optional select case
3473b79
@guerler
Set a declared false on an optional boolean explicitly
55446b6
@guerler
Discover framework tools loaded from a tool_dir
5f5eac9
@guerler
Shard the tool form harness job four ways
4463d50
@guerler
Record the known failures in the tool_dir fixtures
665abe5
@guerler
Drop the failure the core drill down fix resolves
9b47813
@guerler
Record the accessibility baseline failure on the legacy select case
bb6a028
@guerler
Drop the drill down failures the core fix resolves
2480943
@guerler
Drive the select a parameter with many options renders
aeff434
@guerler
Drop the accessibility failures the toggle fix resolves
c9a0547
@guerler
Set collections before the parameters that read from them
f855457
@guerler
Match the comparison tests to the reported values
32d58ff
@guerler
Record the failures the profile gate and CI surfaced
f9db63a
@guerler
Set collections after the conditional that reveals them
ee06335
@guerler
guerler force-pushed the selenium_tool_form.001 branch from 989002e to ee06335 Compare September 2, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/testing kind/enhancement

Projects

None yet

Milestone

26.2

Development

Successfully merging this pull request may close these issues.

1 participant

@guerler