[WIP] Test tool form against the tool request path

.github/workflows/tool_form_harness.yaml

@@ -28,6 +28,8 @@ on:
 env:
   GALAXY_CONFIG_GALAXY_URL_PREFIX: '/galaxypf'
   GALAXY_TEST_E2E_TOOL_TESTS: '1'
+  GALAXY_CONFIG_OVERRIDE_ENABLE_TOOL_REQUESTS: 'true'
+  GALAXY_CONFIG_OVERRIDE_ENABLE_CELERY_TASKS: 'true'
   GALAXY_TEST_DBURI: 'postgresql+psycopg://postgres:postgres@localhost:5432/galaxy?client_encoding=utf8'
   GALAXY_TEST_RAISE_EXCEPTION_ON_HISTORYLESS_HDA: '1'
   GALAXY_TEST_SELENIUM_RETRIES: 1
@@ -50,6 +52,7 @@ jobs:
       fail-fast: false
       matrix:
         python-version: ['3.10']
+        chunk: [0, 1, 2, 3]
     services:
       postgres:
         image: postgres:18
@@ -89,7 +92,7 @@ jobs:
           key: galaxy-static-${{ needs.build-client.outputs.commit-id }}
           path: 'galaxy root/static'
       - name: Run tests
-        run: ./run_tests.sh --coverage -playwright lib/galaxy_test/selenium/test_tool_form_harness.py
+        run: ./run_tests.sh --coverage -playwright lib/galaxy_test/selenium/test_tool_form_harness.py -- --num-shards=4 --shard-id=${{ matrix.chunk }}
         working-directory: 'galaxy root'
       - uses: codecov/codecov-action@v7.0.0
         with:
@@ -98,10 +101,10 @@ jobs:
       - uses: actions/upload-artifact@v7
         if: failure()
         with:
-          name: Tool form harness test results (${{ matrix.python-version }})
+          name: Tool form harness test results (${{ matrix.python-version }}, ${{ matrix.chunk }})
           path: 'galaxy root/run_playwright_tests.html'
       - uses: actions/upload-artifact@v7
         if: failure()
         with:
-          name: Tool form harness debug info (${{ matrix.python-version }})
+          name: Tool form harness debug info (${{ matrix.python-version }}, ${{ matrix.chunk }})
           path: 'galaxy root/database/test_errors'

client/src/utils/navigation/navigation.yml

@@ -758,6 +758,7 @@ tool_form:
     parameter_checkbox: 'div.ui-form-element[id="form-element-${parameter}"] .ui-switch'
     parameter_checkbox_input: 'div.ui-form-element[id="form-element-${parameter}"] input[type="checkbox"]'
     parameter_select: 'div.ui-form-element[id="form-element-${parameter}"] .multiselect'
+    parameter_select_many: 'div.ui-form-element[id="form-element-${parameter}"] .form-select-many'
     parameter_input: 'div.ui-form-element[id="form-element-${parameter}"] .ui-input'
     parameter_textarea: 'div.ui-form-element[id="form-element-${parameter}"] textarea'
     parameter_data_input_single: 'div.ui-form-element[id="form-element-${parameter}"] button[title="Single dataset"]'

lib/galaxy/selenium/navigates_galaxy.py

@@ -24,6 +24,7 @@
     NamedTuple,
     TYPE_CHECKING,
 )
+from urllib.parse import quote
 
 import yaml
 from selenium.webdriver.common.by import By
@@ -1938,6 +1939,15 @@ def tool_open(self, tool_id, outer=False):
         self.scroll_into_view(tool_element)
         tool_link.wait_for_and_click()
 
+    def tool_open_by_url(self, tool_id: str):
+        """Open a tool form by URL rather than through tool panel search.
+
+        Shed and user-defined tools are not always reachable from the panel, and
+        the panel click silently leaves the browser on the current page.
+        """
+        self.get(f"?tool_id={quote(tool_id, safe='')}&version=latest")
+        self.components.tool_form.execute.wait_for_visible()
+
     def datasource_tool_open(self, tool_id):
         tool_link = self.components.tool_panel.data_source_tool_link(tool_id=tool_id)
         tool_element = tool_link.wait_for_present()

lib/galaxy/tool_util/parameters/case.py

@@ -418,7 +418,7 @@ def _merge_into_state(
         handled_inputs.update(_merge_into_state(test_parameter, context, conditional_state, state_path))
         # If the discriminator was omitted, record the when _select_which_when chose so the state
         # validates against that branch rather than the phantom __absent__ branch.
-        if test_parameter.name not in conditional_state and when.discriminator is not None:
+        if when.discriminator is not None and conditional_state.get(test_parameter.name) is None:
             conditional_state[test_parameter.name] = when.discriminator
         # Mark this conditional's discriminator consumed so a nested conditional's loose fallbacks
         # do not re-match it.
@@ -545,7 +545,14 @@ def _select_which_when(
     matched_name = test_input["name"] if test_input else None
     explicit_test_value = test_input["value"] if test_input else None
     if is_boolean and isinstance(explicit_test_value, str):
-        explicit_test_value = asbool(explicit_test_value)
+        truevalue = getattr(test_parameter, "truevalue", None)
+        falsevalue = getattr(test_parameter, "falsevalue", None)
+        if truevalue is not None and explicit_test_value == truevalue:
+            explicit_test_value = True
+        elif falsevalue is not None and explicit_test_value == falsevalue:
+            explicit_test_value = False
+        else:
+            explicit_test_value = asbool(explicit_test_value)
     test_value = validate_explicit_conditional_test_value(test_parameter_name, explicit_test_value)
     if test_value is None:
         # Discriminator omitted: infer the active when from the params the test provides (like

lib/galaxy/tool_util/parameters/factory.py

@@ -354,6 +354,10 @@ def _from_input_source_galaxy(input_source: InputSource, profile: float) -> Tool
             BooleanParameterModel | SelectParameterModel,
             _from_input_source_galaxy(test_param_input_source, profile),
         )
+        if isinstance(test_parameter, BooleanParameterModel) and test_parameter.optional:
+            test_parameter.optional = False
+            if test_parameter.value is None:
+                test_parameter.value = False
         whens = []
         default_test_value = cond_test_parameter_default_value(test_parameter)
         for value, case_inputs_sources in input_source.parse_when_input_sources():