Add tenth-seconds to clock. - #132
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a sense this is unlocked by #120. I've been considering sub-second display for a long time, since the seconds tick slowly when you watch. I thought tenths (with a decimal point) might look bad or heavyweight, and I was considering options such as subscripted numbers. But actually it looks perfectly fine, and I like it a lot better.
I could even go with hundredths since mpg123 outputs them, but they're jumpy and move so fast I don't see how they'd be of any use, and they do look a bit worse in my subjective opinion.
showClockcould probably use tests. Well, maybe I'll get to it.