Use mpg123 --remote-err, drop errorLoop thread. - #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99. This is the recommended approach per that issue, and, as far as I can tell, without this option stderr is not used at all, so
errorLoopwasn't doing anything. I tried commenting out the@Eparsing and inducing an error (seeking in a stopped state), and nothing showed up viaerrorLoop. So it may have been effectively dead code.I do worry there might still be something irregularly emitted on stderr, but I'm deferring to the documentation saying this is the right way to do it.
We no longer need the read handle at all anymore.
Finally, there was a
-argument also sent to mpg123. It may have once done something (or not), but it is apparently irrelevant now.