Miscellaneous code improvements. - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a handful of relatively straightforward issues flagged by a Claude Code review, plus a little more:
genericJumpToMatchis simplified. Thepure(needed for the bespoke helper function) is floated out. Eventually how state is handled should be reformed, but for now this suffices.README.mdis moved toextra-doc-fileswhere it belongs.pSafeHeadand replaced its once use with something else technically safe.mpg123sending invalid output is a remote concern so how it's handled matters little.mergefunction is simplified by going through a Map..mp3extension is better checked for. When filename encodings are in better shape, we could replace withtakeExtension.spacescache is dropped: it's both bad and pointless. Bad, because aP.takefrom a fixed big blank string would be far better. Pointless, because it's likely a minuscule optimization given all the other processing. Maybe this will be a Builder one day..and... This is technically breaking so bumping minor version.ncurseswis moved fromextra-librariestopkgconfig-depends.