Re-Implementation of the Garden Linux/Gardener integration test pipeline by SujanaSubr · Pull Request #422 · gardenlinux/glci

SujanaSubr · 2026-07-16T08:29:20Z

What this PR does / why we need it:
Re-Implementation of the Garden Linux/Gardener integration test pipeline
Which issue(s) this PR fixes:
Fixes #
gardenlinux/gardenlinux#4070
Special notes for your reviewer:

Release note:

Gchbg

See suggested code edits.

Notably missing: unpublish. The unpublish operation needs to remove the cloud profiles, since unpublishing the images makes them invalid. Doing so in a reliable way is not trivial. (For example, since manifests are guaranteed to be atomic and correct, tracking the profiles in the manifests might be a way to do so, or maybe there is a more straighforward solution.)

Not reviewed: internal/nspcpfl
The reason is that I think this is the incorrect approach to doing this, since you have code to handle all cloud providers in there. The rest of GLCI is modular, where understanding and implementation for any given cloud uses the pluggable module framework to contain that knowledge into one file, with the rest of GLCI being unaware of specific cloud implementations. This is a large change and may require evolving the design of GLCI. Because of that I'm open to approving it regardless, with the intention to refactor it later.

Gchbg · 2026-07-27T09:18:59Z

-func (p *Publisher) Publish(ctx context.Context, version, commit string, omitComponentDescritpr bool) error {
+// Publish publishes a release to all cloud providers specified in the flavors and publishing configurations.
+func Publish(ctx context.Context, flavorsConfig FlavorsConfig, publishingConfig PublishingConfig, aliasesConfig AliasesConfig, version,
+	commit string, omitComponentDescritpr bool, omitNSCloudProfile bool,


Suggested change

commit string, omitComponentDescritpr bool, omitNSCloudProfile bool,

commit string, omitComponentDescritpr, omitNSCloudProfile bool,

Gchbg · 2026-07-27T09:19:20Z

+func publish(ctx context.Context, flavorsConfig FlavorsConfig, aliasesConfig AliasesConfig, credsSource credsprovider.CredsSource,
+	manifestSource, manifestTarget cloudprovider.ArtifactSource, sources map[string]cloudprovider.ArtifactSource,
+	targets []cloudprovider.PublishingTarget, ocmTarget cloudprovider.OCMTarget, state task.StatePersistor, version, commit string,
+	omitComponentDescritpr bool, omitNSCloudProfile bool,


Suggested change

omitComponentDescritpr bool, omitNSCloudProfile bool,

omitComponentDescritpr, omitNSCloudProfile bool,

Gchbg · 2026-07-27T09:21:47Z


+	profiles, err := nspcpfl.BuildNSCloudProfiles(version, publications)
+	if err != nil {
+		return fmt.Errorf("error creating Namespaced Cloud Profiles %w", err)


Suggested change

return fmt.Errorf("error creating Namespaced Cloud Profiles %w", err)

return fmt.Errorf("cannot create namespaced cloud profiles: %w", err)

Gchbg · 2026-07-27T09:24:23Z

+	for _, profile := range profiles {
+		profileYAML, err := nspcpfl.ToYAML(profile)
+		if err != nil {
+			return fmt.Errorf("invalid profile configuration: %w", err)


Suggested change

return fmt.Errorf("invalid profile configuration: %w", err)

return fmt.Errorf("invalid cloud profile: %w", err)

Gchbg · 2026-07-27T09:26:58Z

+			NSProfileKey := fmt.Sprintf("meta/NSCloudProfile/%s/%s", version, baseName)
+			if err := manifestTarget.PutObject(ctx, NSProfileKey, bytes.NewReader(profileYAML)); err != nil {
+				return fmt.Errorf("cannot store NSCloudProfile %s: %w", profile.Name, err)
+			}


Suggested change

NSProfileKey := fmt.Sprintf("meta/NSCloudProfile/%s/%s", version, baseName)

if err := manifestTarget.PutObject(ctx, NSProfileKey, bytes.NewReader(profileYAML)); err != nil {

return fmt.Errorf("cannot store NSCloudProfile %s: %w", profile.Name, err)

}

nsProfileKey := fmt.Sprintf("meta/NSCloudProfile/%s/%s", version, baseName)

err = manifestTarget.PutObject(ctx, nsProfileKey, bytes.NewReader(profileYAML))

if err != nil {

return fmt.Errorf("cannot store NSCloudProfile %s: %w", profile.Name, err)

}

Gchbg · 2026-07-27T09:30:32Z

+				return fmt.Errorf("cannot store NSCloudProfile %s: %w", profile.Name, err)
+			}
+
+			shootYAML, err := nspcpfl.BuildShootSpecYAML(version, profile)


Suggested change

shootYAML, err := nspcpfl.BuildShootSpecYAML(version, profile)

var shootYAML []byte

shootYAML, err = nspcpfl.BuildShootSpecYAML(version, profile)

Gchbg · 2026-07-27T09:31:39Z

+				return fmt.Errorf("invalid shoot spec for %s: %w", profile.Name, err)
+			}
+			shootKey := fmt.Sprintf("meta/ShootSpec/%s/%s", version, baseName)
+			if err := manifestTarget.PutObject(ctx, shootKey, bytes.NewReader(shootYAML)); err != nil {


Suggested change

if err := manifestTarget.PutObject(ctx, shootKey, bytes.NewReader(shootYAML)); err != nil {

err = manifestTarget.PutObject(ctx, shootKey, bytes.NewReader(shootYAML))

if err != nil {

Gchbg · 2026-07-27T09:38:10Z

+		if !omitNSCloudProfile {
+			baseName := fmt.Sprintf("gardenlinux-%s-%.8s-%s", nspcpfl.MajorVersion(version), commit, profile.Spec.Parent.Name)
+			NSProfileKey := fmt.Sprintf("meta/NSCloudProfile/%s/%s", version, baseName)
+			if err := manifestTarget.PutObject(ctx, NSProfileKey, bytes.NewReader(profileYAML)); err != nil {


Whether to upload to the manifestTarget is an important design decision. It would mean that cloud profiles go to the same account where the manifests go - dev for dev builds, prod for prod builds.

My understanding is that the profiles are essentially temporary objects that are only useful to run an integration test of a release, and do not need to be persisted. If that is the case, I would expect them to always go to the dev accounts, leaving the prod account for the actual manifests only.

If you believe they should go to the prod accounts instead, then manifestTarget is correct.

Gchbg · 2026-07-27T09:38:56Z

 		}
 	}

+	profiles, err := nspcpfl.BuildNSCloudProfiles(version, publications)


The entire build+upload block for cloud profiles should be garded by the boolean flag.

SujanaSubr requested a review from Gchbg as a code owner July 16, 2026 08:29

Gchbg requested changes Jul 27, 2026

View reviewed changes

SujanaSubr added 6 commits July 28, 2026 11:40

Namespaced Cloud profile and Shootspec preparation for Integration test

e23e3e8

Update yaml files

f7f3f68

Review Comments and small Typo correction

ff30907

Review Comments updated

790029b

Review Comments updated

6886e1d

Rebase to main

588f828

SujanaSubr force-pushed the feat/IntegrationTest branch from 688e11b to 588f828 Compare July 28, 2026 12:27

SujanaSubr added 4 commits July 28, 2026 14:33

Merge branch 'main' into feat/IntegrationTest

eec7248

Missing argument added

fe74a5a

Linter validation update

0bb8abb

Linter validation update

48bfbbf

SujanaSubr marked this pull request as draft July 29, 2026 08:20

SujanaSubr added 2 commits August 10, 2026 09:36

Shoot spec update

bd69424

Add Unpublish

5ad2428

Navigation Menu

Uh oh!

Re-Implementation of the Garden Linux/Gardener integration test pipeline - #422

Re-Implementation of the Garden Linux/Gardener integration test pipeline#422
SujanaSubr wants to merge 12 commits into
mainfrom
feat/IntegrationTest

SujanaSubr commented Jul 16, 2026

Uh oh!

Gchbg left a comment

Uh oh!

Gchbg Jul 27, 2026

Uh oh!

Gchbg Jul 27, 2026

Uh oh!

Gchbg Jul 27, 2026

Uh oh!

Gchbg Jul 27, 2026

Uh oh!

Gchbg Jul 27, 2026

Uh oh!

Gchbg Jul 27, 2026

Uh oh!

Gchbg Jul 27, 2026

Uh oh!

Gchbg Jul 27, 2026

Uh oh!

Gchbg Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	commit string, omitComponentDescritpr bool, omitNSCloudProfile bool,
	commit string, omitComponentDescritpr, omitNSCloudProfile bool,

	omitComponentDescritpr bool, omitNSCloudProfile bool,
	omitComponentDescritpr, omitNSCloudProfile bool,

	return fmt.Errorf("error creating Namespaced Cloud Profiles %w", err)
	return fmt.Errorf("cannot create namespaced cloud profiles: %w", err)

	return fmt.Errorf("invalid profile configuration: %w", err)
	return fmt.Errorf("invalid cloud profile: %w", err)

	shootYAML, err := nspcpfl.BuildShootSpecYAML(version, profile)
	var shootYAML []byte
	shootYAML, err = nspcpfl.BuildShootSpecYAML(version, profile)

	if err := manifestTarget.PutObject(ctx, shootKey, bytes.NewReader(shootYAML)); err != nil {
	err = manifestTarget.PutObject(ctx, shootKey, bytes.NewReader(shootYAML))
	if err != nil {

Uh oh!

Conversation

SujanaSubr commented Jul 16, 2026

Uh oh!

Gchbg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants