Skip to content

Suggested Improvement - Don't move or modify input file #1

Description

@markjschreiber

In the workflow an input file is moved to another location. Not exactly a bug (except in miniwdl where you are not allowed to do this). But it can be hazardous because other steps in a workflow might expect the file to still be there (especially scatters).

The line:

mv ~{input_file} ~{new_name}

would be better as

cp ~{input_file} ~{new_name}

In general it would be safer to avoid making any changes to the location or content of an input if you can.

Happy to submit a PR if you agree.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions