Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two independent event-ordering issues affected the CS8409 user services:
cs8409-mixer.servicewas marked failed when WirePlumber had not selected a default source yet or PipeWire had not createdcs8409_speakers. The mandatory ALSA mic controls had already succeeded.cs8409-dsp-unity-lock.shreacted to every PulseAudio event by launchingpactl set-sink-volume. Each invocation created more client and sink events, retriggering the helper indefinitely.The feedback loop generated 1,024 events in three seconds and sustained approximately 33% CPU in WirePlumber, 22% in PipeWire Pulse, and 20% in PipeWire.
Changes
ExecStart=-prefix.cs8409_speakersfirst and write only when it is not already at 100%.A real DSP sink volume change now produces at most one corrective write. Its resulting event performs a read, sees unity, and stops.
Validation
Validated on MacBookPro14,3 / PipeWire with the CS8409 filter graph active:
bash -n pipewire/cs8409-dsp-unity-lock.shgit diff --checkcs8409_speakersto 90% restored it to 100% / 0.00 dB within one secondUser-facing volume remains on the downstream four-channel hardware node; this helper only holds the DSP filter sink at unity as designed.