Skip to content

Commit 096c92f

Browse files
authored
Merge pull request #182 from gdg-ibadan01/staging
fix: ticket generation error
2 parents e15d969 + 4b807a7 commit 096c92f

1 file changed

Lines changed: 26 additions & 15 deletions

File tree

backend/src/modules/order/order.service.ts

Lines changed: 26 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -356,26 +356,37 @@ export class OrdersService {
356356
OrdersService.ERRORS.OrderNotFoundErr,
357357
);
358358
}
359-
let pdfBuffer: Buffer<ArrayBuffer> | undefined;
359+
let pdfBuffer: Buffer<ArrayBuffer> | undefined | void;
360360
if (!order.ticketUrl) {
361-
pdfBuffer = await this.pdfService.generateDevFest2026Ticket({
362-
amount: order.amount.toNumber(),
363-
ticketCode: order.reference.slice(-6),
364-
downloadUrl: this.generateSignedDownloadUrl(order.reference),
365-
validity: order.ticket.validityDates.map((d) =>
366-
d.toLocaleDateString('en-US', { weekday: 'long' }),
367-
),
368-
});
361+
pdfBuffer = await this.pdfService
362+
.generateDevFest2026Ticket({
363+
amount: order.amount.toNumber(),
364+
ticketCode: order.reference.slice(-6),
365+
downloadUrl: this.generateSignedDownloadUrl(order.reference),
366+
validity: order.ticket.validityDates.map((d) =>
367+
d.toLocaleDateString('en-US', { weekday: 'long' }),
368+
),
369+
})
370+
.catch((err) => this.logger.error(err))
371+
.then((res) => {
372+
this.logger.debug('pdfBuffer generated successfully');
373+
return res;
374+
});
369375
}
370376

371377
let ticketUrl: string | undefined;
372378
if (pdfBuffer) {
373-
const upload = await this.uploadService.uploadFile(pdfBuffer);
374-
ticketUrl = upload?.secure_url;
375-
await this.prisma.order.update({
376-
where: { id: order.id },
377-
data: { ticketUrl },
378-
});
379+
await this.uploadService
380+
.uploadFile(pdfBuffer)
381+
.then(async (upload) => {
382+
ticketUrl = upload?.secure_url;
383+
await this.prisma.order.update({
384+
where: { id: order.id },
385+
data: { ticketUrl },
386+
});
387+
return upload;
388+
})
389+
.catch((err) => this.logger.error(err));
379390
}
380391

381392
return {

0 commit comments

Comments
 (0)