feat: share HCR060 escape gate; withhold fix on argument/initializer escapes - #223
Open
georgepwall1991 wants to merge 4 commits into
Open
georgepwall1991 wants to merge 4 commits into
georgepwall1991 wants to merge 4 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 7, 2026
georgepwall1991
changed the title
Extract VariableEscapesScope into internal UsingDeclarationEscapeGate so HCR081 can reuse it, and extend the escape definition to values passed as arguments (including parenthesized). Direct unit tests cover every gate branch; behavior test covers the argument case.
georgepwall1991
force-pushed
the
codex/iteration-21-hcr060-escape-guard
branch
from
September 7, 2026 19:23
b28c355 to
5e2513b
Compare
georgepwall1991
force-pushed
the
codex/iteration-27-hcr060-shared-gate
branch
from
September 7, 2026 19:23
fbf6309 to
e6c9ae7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #218. Extracts the escape check into internal UsingDeclarationEscapeGate (Block-or-CompilationUnit scope idiom per ServiceRegistrationCollector) and extends escape to argument transfers, parenthesized arguments, and object/collection initializers; member-access receivers stay fix-eligible. Coverage: 13 direct gate unit tests (mutant killer per branch), behavior tests for direct/split/top-level/member/argument/initializer escapes. Verified: 970/970, format clean. Codex review pending (CLI limited to Sep 12).