Refactor: Revert changes from #309 after introducing separate selected option - #310
Merged
Merged
Conversation
ftes
marked this pull request as ready for review
April 23, 2026 19:23
Owner
No worries. I appreciate the follow-up. And I'll take it! Less code is better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #309.
With the new approach (separate
selectedoption), some changes to existingvaluefinder path became unnecessary.Sorry, I realized this a little too late.
Take this or leave it - #309 was ok - just a bit more bloated than it had to be.