Fix live-register access after accessor refactor - #5
Merged
Conversation
The accessor split left several ARM and AArch64 live-register paths calling methods on the disassembler itself. Enabling register annotations therefore raised AttributeError instead of returning disassembly. Route all remaining register and processor-state reads through the access object, matching the restructured ownership of those operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix live-register annotations after disassembly access functions were moved
out of the architecture decoders and into the accessor object.
Several ARM and AArch64 paths still called
get_reg()orget_pstate()onthe decoder itself. Enabling live-register annotations therefore raised an
AttributeErrorinstead of producing disassembly.Changes
self.access.self.access.Testing
make testssuccessfully.MOVinstructions withlive_registers=Trueandconfirmed that both produce the expected register-value annotations.