feat: Add external_id to Customer and Subscription index - #542
Conversation
sarkissianraffi
left a comment
There was a problem hiding this comment.
Verified against the API code: the customers index permits external_id as a filter, and the subscriptions side is served by SubscriptionsQuery's with_external_id. Both params documented here are real behavior the spec was missing. Bundle in sync, lint gate passes.
One coordination note inline about overlap with #557. Approving.
| parameters: | ||
| - $ref: '../parameters/page.yaml' | ||
| - $ref: '../parameters/per_page.yaml' | ||
| - name: external_id |
|
This branch went CONFLICTING after the last merge round, so here is a conflict-free rebase, ready to take: What the resolution keeps and drops, verified param-by-param against the bundled spec:
Bundle regenerated and in sync. Gates pass at main's exact baseline (0 errors, 23 warnings). Verified every one of the three endpoints now carries Reset this branch to |
…the /customers and /subscriptions halves that landed on main and in #557
|
Update: resolved the conflict directly on this branch instead, via a merge commit from main (your commits untouched, no rewrite). The interim branch from my previous comment is deleted. Resolution, verified param-by-param on the rebuilt bundle: the GitHub now reports the PR mergeable. My approval stands. |
Description
This PR adds docs for the
external_idfilter to customer and subscription index. This is the part of: