docs(readme): point stars badge at the repo, not /stargazers - #948
Open
jgrund wants to merge 1 commit into
Open
Conversation
GitHub now returns 404 for /stargazers to logged-out clients (it does for every repository), so the badge target was a dead link for anonymous visitors and the docs link-checker (getnora-io#727) fails on every PR. Signed-off-by: Joe Grund <grundjoseph@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One-line README fix: the GitHub-stars badge linked to
/stargazers, which GitHub now serves as 404 to logged-out clients (try any repository's/stargazerswhile signed out —rust-lang/rustincluded). Point the badge at the repository instead.Why
The link is dead for anonymous visitors, and the docs link-checker added in #941 correctly rejects it — currently failing the
Check Markdown Linksjob on every PR (e.g. #947).Checklist
cargo test) — docs-only change