fix(editor): offer 3D Orbit only with a recorded cursor

The moving camera follows the cursor under Auto focus, and a take recorded with the system cursor writes no .cursor.json for the compositor to read, so picking 3D Orbit silently held still (#1397). Not offered under Auto focus when the take carries no cursor data; Manual focus still offers it, where the focus point poses it, and a stored orbit stays listed so the row can show it.

Author: EtienneLescot

src/components/ai-edition/v4/FloatingInspector.test.tsx

@@ -367,7 +367,53 @@ describe("FloatingInspector", () => {
 				"button",
 			);
 
+		/** A project whose one take recorded `samples` cursor samples, and the read answering it. */
+		function openTake(samples: number) {
+			const originalPath = `/recordings/${crypto.randomUUID()}.mp4`;
+			const asset = assetSchema.parse({ id: "a1", label: "take", originalPath });
+			const clip = clipSchema.parse({
+				id: "c1",
+				assetId: "a1",
+				sourceStartSec: 0,
+				sourceEndSec: 10,
+				timelineStartSec: 0,
+				timelineEndSec: 10,
+				origin: "user",
+			});
+			const read = vi
+				.spyOn(nativeBridgeClient.cursor, "getRecordingData")
+				.mockImplementation(async () => ({
+					version: 2,
+					provider: "native",
+					assets: [],
+					samples: Array.from({ length: samples }, (_, i) => ({
+						timeMs: i * 100,
+						cx: 0.5,
+						cy: 0.5,
+					})),
+				}));
+			const document = createEmptyDocument({ projectId: "p", title: "t" });
+			useProjectStore.setState({
+				projectId: "p",
+				document: {
+					...document,
+					assets: [asset],
+					timeline: { ...document.timeline, clips: [clip] },
+				},
+			});
+			return read;
+		}
+
+		/** Lets the take's cursor file be read, so an absence is an answer and not a wait. */
+		async function readTake(read: ReturnType<typeof openTake>) {
+			await waitFor(() => expect(read).toHaveBeenCalled());
+			await act(async () => {
+				await Promise.all(read.mock.results.map((result) => result.value));
+			});
+		}
+
 		afterEach(() => {
+			vi.restoreAllMocks();
 			useProjectStore.setState({ document: null });
 		});
 
@@ -459,6 +505,33 @@ describe("FloatingInspector", () => {
 				editorSettings.autoFocusAll = false;
 			}
 		});
+
+		// Issue #1397. A take recorded with the system cursor has no cursor file, so Auto focus
+		// has nothing to read and 3D Orbit would hold still — exactly the camera the reporter
+		// picked and then watched do nothing.
+		it("leaves the orbit out under Auto focus when the take has no recorded cursor", async () => {
+			const read = openTake(0);
+			const { tl } = zoomTl({ focusMode: "auto" });
+			render(<FloatingInspector {...defaultProps} tl={tl} />);
+			await readTake(read);
+			expect(
+				screen.queryByRole("button", { name: "settings.zoom.camera.preset.orbit" }),
+			).toBeNull();
+			// The fixed angles need no cursor, so they stay.
+			expect(
+				screen.getByRole("button", { name: "settings.zoom.camera.preset.left" }),
+			).toBeInTheDocument();
+		});
+
+		it("offers the orbit under Auto focus once the take has a recorded cursor", async () => {
+			const read = openTake(3);
+			const { tl } = zoomTl({ focusMode: "auto" });
+			render(<FloatingInspector {...defaultProps} tl={tl} />);
+			await readTake(read);
+			expect(
+				await screen.findByRole("button", { name: "settings.zoom.camera.preset.orbit" }),
+			).toBeInTheDocument();
+		});
 	});
 
 	describe("cursor facet", () => {

src/components/ai-edition/v4/FloatingInspector.tsx

@@ -173,7 +173,7 @@ export function FloatingInspector({
 			{effectiveOpen ? (
 				<div className={styles.inspector}>
 					{selection ? (
-						<SelectionPane tl={tl} onClose={() => tl.clearSelection()} />
+						<SelectionPane tl={tl} onClose={() => tl.clearSelection()} hasCursor={hasCursor} />
 					) : audioTrackSelected ? (
 						<AudioTrackPane tl={tl} onClose={() => tl.clearSelection()} />
 					) : (
@@ -743,7 +743,17 @@ export function AnnotationSizeField({
 	);
 }
 
-function SelectionPane({ tl, onClose }: { tl: TimelineApi; onClose: () => void }) {
+function SelectionPane({
+	tl,
+	onClose,
+	hasCursor,
+}: {
+	tl: TimelineApi;
+	onClose: () => void;
+	/** Whether a recording on the timeline carries cursor data, as decided once for the whole
+	 *  inspector: the 3D Orbit reads it, so a take without one cannot use it under Auto focus. */
+	hasCursor: boolean;
+}) {
 	const ts = useScopedT("settings");
 	const tt = useScopedT("timeline");
 	const tc = useScopedT("common");
@@ -852,11 +862,12 @@ function SelectionPane({ tl, onClose }: { tl: TimelineApi; onClose: () => void }
 								tiles
 								options={[
 									"off" as const,
-									// The orbit follows the cursor under auto focus, and a hidden cursor drives
-									// nothing: not offered then, rather than a camera that silently holds still.
-									// Under manual focus the focus point poses it, cursor or not. Still listed
-									// once picked, so the row can show it.
-									...(settings.cursorShow ||
+									// The orbit follows the cursor under auto focus, so it needs one the compositor
+									// can read: a recording made with the system cursor writes no cursor file, and
+									// a hidden cursor drives nothing. Not offered then, rather than a camera that
+									// silently holds still. Under manual focus the focus point poses it, cursor or
+									// not. Still listed once picked, so the row can show it.
+									...((hasCursor && settings.cursorShow) ||
 									(!autoFocusAll && (region.focusMode ?? "manual") === "manual") ||
 									region.rotationPreset === "orbit"
 										? MOVING_ROTATION_3D_PRESETS