|
| 1 | +// The MCP settings actions take renderer input, so the bridge checks its types |
| 2 | +// before anything reaches the settings store: a bad value is an INVALID_REQUEST, |
| 3 | +// not an INTERNAL_ERROR thrown further in. |
| 4 | + |
| 5 | +import { beforeEach, describe, expect, it, vi } from "vitest"; |
| 6 | +import type { NativeBridgeResponse } from "../../src/native/contracts"; |
| 7 | +import { type NativeBridgeContext, registerNativeBridgeHandlers } from "./nativeBridge"; |
| 8 | + |
| 9 | +const electron = vi.hoisted(() => ({ handle: vi.fn() })); |
| 10 | +vi.mock("electron", () => ({ |
| 11 | + app: { getAppPath: () => "", isPackaged: false }, |
| 12 | + ipcMain: { handle: electron.handle, removeHandler: vi.fn() }, |
| 13 | + shell: {}, |
| 14 | +})); |
| 15 | +vi.mock("../native-bridge/services/compositorViewService", () => ({ |
| 16 | + CompositorViewService: class {}, |
| 17 | +})); |
| 18 | + |
| 19 | +const service = vi.hoisted(() => ({ |
| 20 | + mcpSetEnabled: vi.fn(async () => ({ ok: "enabled" })), |
| 21 | + mcpSetPort: vi.fn(async () => ({ ok: "port" })), |
| 22 | + mcpSetAllowEdits: vi.fn(async () => ({ ok: "allowEdits" })), |
| 23 | +})); |
| 24 | +vi.mock("../native-bridge/services/aiEditionService", () => ({ |
| 25 | + AiEditionService: class { |
| 26 | + mcpSetEnabled = service.mcpSetEnabled; |
| 27 | + mcpSetPort = service.mcpSetPort; |
| 28 | + mcpSetAllowEdits = service.mcpSetAllowEdits; |
| 29 | + }, |
| 30 | +})); |
| 31 | + |
| 32 | +let invoke: (action: string, payload: unknown) => Promise<NativeBridgeResponse>; |
| 33 | + |
| 34 | +beforeEach(() => { |
| 35 | + electron.handle.mockClear(); |
| 36 | + for (const fn of Object.values(service)) fn.mockClear(); |
| 37 | + registerNativeBridgeHandlers({ |
| 38 | + getPlatform: () => "linux", |
| 39 | + getAiEditionDocuments: () => ({}), |
| 40 | + getAiEditionLlmConfig: () => ({}), |
| 41 | + } as unknown as NativeBridgeContext); |
| 42 | + const handler = electron.handle.mock.calls[0]?.[1] as ( |
| 43 | + event: unknown, |
| 44 | + request: unknown, |
| 45 | + ) => Promise<NativeBridgeResponse>; |
| 46 | + invoke = (action, payload) => |
| 47 | + handler({ sender: {} }, { domain: "aiEdition", action, payload, requestId: "r" }); |
| 48 | +}); |
| 49 | + |
| 50 | +function errorCode(response: NativeBridgeResponse): string | undefined { |
| 51 | + return response.ok ? undefined : response.error?.code; |
| 52 | +} |
| 53 | + |
| 54 | +describe("native bridge MCP settings", () => { |
| 55 | + it.each([80, 70000, 4.5, "47821", null])("rejects port %s as a bad request", async (port) => { |
| 56 | + expect(errorCode(await invoke("mcp.setPort", { port }))).toBe("INVALID_REQUEST"); |
| 57 | + expect(service.mcpSetPort).not.toHaveBeenCalled(); |
| 58 | + }); |
| 59 | + |
| 60 | + it("passes a valid port on", async () => { |
| 61 | + const response = await invoke("mcp.setPort", { port: 47821 }); |
| 62 | + expect(response.ok).toBe(true); |
| 63 | + expect(service.mcpSetPort).toHaveBeenCalledWith(47821); |
| 64 | + }); |
| 65 | + |
| 66 | + it.each(["true", 1, undefined])("rejects enabled=%s as a bad request", async (enabled) => { |
| 67 | + expect(errorCode(await invoke("mcp.setEnabled", { enabled }))).toBe("INVALID_REQUEST"); |
| 68 | + expect(service.mcpSetEnabled).not.toHaveBeenCalled(); |
| 69 | + }); |
| 70 | + |
| 71 | + it.each(["yes", 0, undefined])("rejects allowEdits=%s as a bad request", async (allowEdits) => { |
| 72 | + expect(errorCode(await invoke("mcp.setAllowEdits", { allowEdits }))).toBe("INVALID_REQUEST"); |
| 73 | + expect(service.mcpSetAllowEdits).not.toHaveBeenCalled(); |
| 74 | + }); |
| 75 | + |
| 76 | + it("passes valid flags on", async () => { |
| 77 | + await invoke("mcp.setEnabled", { enabled: true }); |
| 78 | + await invoke("mcp.setAllowEdits", { allowEdits: false }); |
| 79 | + expect(service.mcpSetEnabled).toHaveBeenCalledWith(true); |
| 80 | + expect(service.mcpSetAllowEdits).toHaveBeenCalledWith(false); |
| 81 | + }); |
| 82 | +}); |
0 commit comments