Skip to content

Commit 6cf5bdc

Browse files
EtienneLescotEtienneLescot
committed
docs: a source dropped on the clip row is appended, there is no split-and-insert dialog
InsertSourceModal lost its render site when the v3 editor shell landed and has been dead since: dropping a source anywhere on the clip row appends it. Remove the component and its insertSourceDialog strings, and stop the media library, intro and product-demo guide (English and 7 translations) from promising the Add before / Add after / Split here and insert choice or clip splitting.
1 parent c41a416 commit 6cf5bdc

40 files changed

Lines changed: 32 additions & 288 deletions

File tree

‎src/components/ai-edition/Modals.tsx‎

Lines changed: 0 additions & 98 deletions
Original file line numberDiff line numberDiff line change
@@ -1354,104 +1354,6 @@ export function UnsavedChangesModal({
13541354
);
13551355
}
13561356

1357-
export interface InsertSourceModalProps extends BaseModalProps {
1358-
assetLabel: string;
1359-
canAddBefore: boolean;
1360-
canAddAfter: boolean;
1361-
canSplit: boolean;
1362-
onAddBefore: () => void;
1363-
onAddAfter: () => void;
1364-
onSplit: () => void;
1365-
}
1366-
1367-
export function InsertSourceModal({
1368-
open,
1369-
onClose,
1370-
assetLabel,
1371-
canAddBefore,
1372-
canAddAfter,
1373-
canSplit,
1374-
onAddBefore,
1375-
onAddAfter,
1376-
onSplit,
1377-
}: InsertSourceModalProps) {
1378-
const t = useScopedT("editor");
1379-
return (
1380-
<ModalShell
1381-
open={open}
1382-
onClose={onClose}
1383-
title={t("insertSourceDialog.title")}
1384-
subtitle={t("insertSourceDialog.subtitle", { assetLabel })}
1385-
>
1386-
<div style={{ display: "flex", flexDirection: "column", gap: 8 }}>
1387-
<button
1388-
type="button"
1389-
disabled={!canAddBefore}
1390-
onClick={onAddBefore}
1391-
style={{
1392-
padding: "12px 16px",
1393-
border: "1px solid transparent",
1394-
borderRadius: 12,
1395-
background: "color-mix(in oklab, var(--fg) 5%, transparent)",
1396-
color: "var(--fg-2)",
1397-
font: "500 13px/1.2 var(--font-body)",
1398-
cursor: canAddBefore ? "pointer" : "not-allowed",
1399-
textAlign: "left",
1400-
opacity: canAddBefore ? 1 : 0.5,
1401-
}}
1402-
>
1403-
<strong>{t("insertSourceDialog.addBefore")}</strong>
1404-
<div style={{ fontSize: 12, color: "var(--muted)", marginTop: 2 }}>
1405-
{t("insertSourceDialog.addBeforeDesc")}
1406-
</div>
1407-
</button>
1408-
<button
1409-
type="button"
1410-
disabled={!canAddAfter}
1411-
onClick={onAddAfter}
1412-
style={{
1413-
padding: "12px 16px",
1414-
border: "1px solid transparent",
1415-
borderRadius: 12,
1416-
background: "color-mix(in oklab, var(--fg) 5%, transparent)",
1417-
color: "var(--fg-2)",
1418-
font: "500 13px/1.2 var(--font-body)",
1419-
cursor: canAddAfter ? "pointer" : "not-allowed",
1420-
textAlign: "left",
1421-
opacity: canAddAfter ? 1 : 0.5,
1422-
}}
1423-
>
1424-
<strong>{t("insertSourceDialog.addAfter")}</strong>
1425-
<div style={{ fontSize: 12, color: "var(--muted)", marginTop: 2 }}>
1426-
{t("insertSourceDialog.addAfterDesc")}
1427-
</div>
1428-
</button>
1429-
<button
1430-
type="button"
1431-
disabled={!canSplit}
1432-
onClick={onSplit}
1433-
style={{
1434-
padding: "12px 16px",
1435-
border: "1px solid transparent",
1436-
borderRadius: 12,
1437-
background: "color-mix(in oklab, var(--fg) 5%, transparent)",
1438-
color: "var(--fg-2)",
1439-
font: "500 13px/1.2 var(--font-body)",
1440-
cursor: canSplit ? "pointer" : "not-allowed",
1441-
textAlign: "left",
1442-
opacity: canSplit ? 1 : 0.5,
1443-
}}
1444-
>
1445-
<strong>{t("insertSourceDialog.split")}</strong>
1446-
<div style={{ fontSize: 12, color: "var(--muted)", marginTop: 2 }}>
1447-
{t("insertSourceDialog.splitDesc")}
1448-
</div>
1449-
</button>
1450-
</div>
1451-
</ModalShell>
1452-
);
1453-
}
1454-
14551357
export interface ChatHistoryModalProps extends BaseModalProps {
14561358
sessions: Array<{ id: string; title: string; messageCount: number; createdAt: string }>;
14571359
activeSessionId: string | null;

‎src/i18n/locales/ar/editor.json‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -338,16 +338,6 @@
338338
"pickClipTitle": "اختر مقطعًا لتعديله",
339339
"clipLabel": "المقطع {{index}}"
340340
},
341-
"insertSourceDialog": {
342-
"title": "إدراج المصدر",
343-
"subtitle": "أين تريد وضع \"{{assetLabel}}\" على الجدول الزمني؟",
344-
"addBefore": "إضافة قبل",
345-
"addBeforeDesc": "إدراج المصدر بالكامل قبل المقطع المستهدف.",
346-
"addAfter": "إضافة بعد",
347-
"addAfterDesc": "إدراج المصدر بالكامل بعد المقطع المستهدف.",
348-
"split": "تقسيم هنا وإدراج",
349-
"splitDesc": "تقسيم المقطع المستهدف عند نقطة الإفلات وإدراج المصدر بينهما."
350-
},
351341
"cropDialog": {
352342
"subtitle": "اسحب المنطقة أو مقابضها لضبط منطقة القص"
353343
},

‎src/i18n/locales/cs/editor.json‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -338,16 +338,6 @@
338338
"pickClipTitle": "Vyberte klip k úpravě",
339339
"clipLabel": "Klip {{index}}"
340340
},
341-
"insertSourceDialog": {
342-
"title": "Vložit zdroj",
343-
"subtitle": "Kam umístit „{{assetLabel}}” na časové ose?",
344-
"addBefore": "Přidat před",
345-
"addBeforeDesc": "Vložit celý zdroj před cílový klip.",
346-
"addAfter": "Přidat za",
347-
"addAfterDesc": "Vložit celý zdroj za cílový klip.",
348-
"split": "Rozdělit zde a vložit",
349-
"splitDesc": "Rozdělit cílový klip v místě přetažení a vložit zdroj mezi ně."
350-
},
351341
"cropDialog": {
352342
"subtitle": "Přetáhněte oblast nebo její úchyty pro úpravu plochy oříznutí"
353343
},

‎src/i18n/locales/de/editor.json‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -338,16 +338,6 @@
338338
"pickClipTitle": "Wähle einen Clip zum Bearbeiten",
339339
"clipLabel": "Clip {{index}}"
340340
},
341-
"insertSourceDialog": {
342-
"title": "Quelle einfügen",
343-
"subtitle": "Wo soll „{{assetLabel}}“ auf der Timeline platziert werden?",
344-
"addBefore": "Davor einfügen",
345-
"addBeforeDesc": "Die ganze Quelle vor dem Ziel-Clip einfügen.",
346-
"addAfter": "Danach einfügen",
347-
"addAfterDesc": "Die ganze Quelle nach dem Ziel-Clip einfügen.",
348-
"split": "Hier teilen und einfügen",
349-
"splitDesc": "Den Ziel-Clip am Ablagepunkt teilen und die Quelle dazwischen einfügen."
350-
},
351341
"cropDialog": {
352342
"subtitle": "Zieh den Bereich oder seine Griffe, um den Ausschnitt anzupassen"
353343
},

‎src/i18n/locales/en/editor.json‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -338,16 +338,6 @@
338338
"pickClipTitle": "Choose a clip to edit",
339339
"clipLabel": "Clip {{index}}"
340340
},
341-
"insertSourceDialog": {
342-
"title": "Insert source",
343-
"subtitle": "Where to place \"{{assetLabel}}\" on the timeline?",
344-
"addBefore": "Add before",
345-
"addBeforeDesc": "Insert the whole source before the target clip.",
346-
"addAfter": "Add after",
347-
"addAfterDesc": "Insert the whole source after the target clip.",
348-
"split": "Split here and insert",
349-
"splitDesc": "Split the target clip at the drop point and insert the source in between."
350-
},
351341
"cropDialog": {
352342
"subtitle": "Drag the region or its handles to adjust the crop area"
353343
},

‎src/i18n/locales/es/editor.json‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -338,16 +338,6 @@
338338
"pickClipTitle": "Elige un clip para editar",
339339
"clipLabel": "Clip {{index}}"
340340
},
341-
"insertSourceDialog": {
342-
"title": "Insertar fuente",
343-
"subtitle": "¿Dónde colocar \"{{assetLabel}}\" en la línea de tiempo?",
344-
"addBefore": "Añadir antes",
345-
"addBeforeDesc": "Inserta toda la fuente antes del clip de destino.",
346-
"addAfter": "Añadir después",
347-
"addAfterDesc": "Inserta toda la fuente después del clip de destino.",
348-
"split": "Dividir aquí e insertar",
349-
"splitDesc": "Divide el clip de destino en el punto de soltar e inserta la fuente entre medias."
350-
},
351341
"cropDialog": {
352342
"subtitle": "Arrastra la región o sus controles para ajustar el área de recorte"
353343
},

‎src/i18n/locales/fr/editor.json‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -338,16 +338,6 @@
338338
"pickClipTitle": "Choisissez un clip à modifier",
339339
"clipLabel": "Clip {{index}}"
340340
},
341-
"insertSourceDialog": {
342-
"title": "Insérer la source",
343-
"subtitle": "Où placer « {{assetLabel}} » sur la timeline ?",
344-
"addBefore": "Ajouter avant",
345-
"addBeforeDesc": "Insère toute la source avant le clip cible.",
346-
"addAfter": "Ajouter après",
347-
"addAfterDesc": "Insère toute la source après le clip cible.",
348-
"split": "Diviser ici et insérer",
349-
"splitDesc": "Divise le clip cible au point de dépose et insère la source entre les deux."
350-
},
351341
"cropDialog": {
352342
"subtitle": "Faites glisser la zone ou ses poignées pour ajuster la zone de recadrage"
353343
},

‎src/i18n/locales/it/editor.json‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -338,16 +338,6 @@
338338
"pickClipTitle": "Scegli una clip da modificare",
339339
"clipLabel": "Clip {{index}}"
340340
},
341-
"insertSourceDialog": {
342-
"title": "Inserisci sorgente",
343-
"subtitle": "Dove posizionare \"{{assetLabel}}\" sulla timeline?",
344-
"addBefore": "Aggiungi prima",
345-
"addBeforeDesc": "Inserisce l'intera sorgente prima della clip di destinazione.",
346-
"addAfter": "Aggiungi dopo",
347-
"addAfterDesc": "Inserisce l'intera sorgente dopo la clip di destinazione.",
348-
"split": "Dividi qui e inserisci",
349-
"splitDesc": "Divide la clip di destinazione nel punto di rilascio e inserisce la sorgente in mezzo."
350-
},
351341
"cropDialog": {
352342
"subtitle": "Trascina l'area o le sue maniglie per regolare l'area di ritaglio"
353343
},

‎src/i18n/locales/ja-JP/editor.json‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -338,16 +338,6 @@
338338
"pickClipTitle": "編集するクリップを選択",
339339
"clipLabel": "クリップ {{index}}"
340340
},
341-
"insertSourceDialog": {
342-
"title": "ソースを挿入",
343-
"subtitle": "「{{assetLabel}}」をタイムラインのどこに配置しますか？",
344-
"addBefore": "前に追加",
345-
"addBeforeDesc": "対象クリップの前にソース全体を挿入します。",
346-
"addAfter": "後に追加",
347-
"addAfterDesc": "対象クリップの後にソース全体を挿入します。",
348-
"split": "ここで分割して挿入",
349-
"splitDesc": "ドロップ位置で対象クリップを分割し、その間にソースを挿入します。"
350-
},
351341
"cropDialog": {
352342
"subtitle": "領域またはハンドルをドラッグして切り抜き範囲を調整します"
353343
},

‎src/i18n/locales/ko-KR/editor.json‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -338,16 +338,6 @@
338338
"pickClipTitle": "편집할 클립 선택",
339339
"clipLabel": "클립 {{index}}"
340340
},
341-
"insertSourceDialog": {
342-
"title": "소스 삽입",
343-
"subtitle": "\"{{assetLabel}}\"을(를) 타임라인 어디에 배치할까요?",
344-
"addBefore": "앞에 추가",
345-
"addBeforeDesc": "대상 클립 앞에 전체 소스를 삽입합니다.",
346-
"addAfter": "뒤에 추가",
347-
"addAfterDesc": "대상 클립 뒤에 전체 소스를 삽입합니다.",
348-
"split": "여기서 분할하여 삽입",
349-
"splitDesc": "드롭 지점에서 대상 클립을 분할하고 그 사이에 소스를 삽입합니다."
350-
},
351341
"cropDialog": {
352342
"subtitle": "영역이나 핸들을 드래그하여 자르기 영역을 조정하세요"
353343
},

0 commit comments

Comments
 (0)