Skip to content

Commit 72d81f2

Browse files
committed
fix(stt): align build script binary names with gpuDetector expectations
binaryNameForBackend('ctranslate2-cpu') → 'ctranslate2-server-ctranslate2-cpu.exe' but build scripts produced 'ctranslate2-server-cpu.exe' (missing ctranslate2- prefix). - ct2-build.cmd: copy output to ctranslate2-server-ctranslate2-cpu.exe - scripts/build-ctranslate2-server.sh: variant names cpu→ctranslate2-cpu, cuda→ctranslate2-cuda
1 parent 78529ac commit 72d81f2

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎ct2-build.cmd‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ cmake -S electron\native\ctranslate2-server -B .cache\ctranslate2-build\build-cp
55
if errorlevel 1 exit /b %errorlevel%
66
cmake --build .cache\ctranslate2-build\build-cpu --config Release
77
if errorlevel 1 exit /b %errorlevel%
8-
copy /Y .cache\ctranslate2-build\build-cpu\ctranslate2-server.exe electron\native\bin\win32-x64\ctranslate2-server-cpu.exe
8+
copy /Y .cache\ctranslate2-build\build-cpu\ctranslate2-server.exe electron\native\bin\win32-x64\ctranslate2-server-ctranslate2-cpu.exe
99
echo Build complete.

‎scripts/build-ctranslate2-server.sh‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ VARIANTS=()
3232
while [[ $# -gt 0 ]]; do
3333
case "$1" in
3434
--cpu-only) CPU_ONLY=1; shift ;;
35-
--cuda) VARIANTS+=("cuda"); shift ;;
36-
--cpu) VARIANTS+=("cpu"); shift ;;
35+
--cuda) VARIANTS+=("ctranslate2-cuda"); shift ;;
36+
--cpu) VARIANTS+=("ctranslate2-cpu"); shift ;;
3737
-h|--help)
3838
cat <<-EOF
3939
Usage: $0 [--cpu-only | --cuda --cpu]
@@ -50,22 +50,22 @@ done
5050

5151
if [[ "${#VARIANTS[@]}" -eq 0 && "${CPU_ONLY}" -eq 0 ]]; then
5252
case "$(uname -s):$(uname -m)" in
53-
Darwin:arm64|Darwin:x86_64) VARIANTS+=(cpu) ;;
53+
Darwin:arm64|Darwin:x86_64) VARIANTS+=(ctranslate2-cpu) ;;
5454
Linux:x86_64|Linux:aarch64)
55-
if command -v nvcc >/dev/null 2>&1; then VARIANTS+=(cuda); fi
56-
VARIANTS+=(cpu)
55+
if command -v nvcc >/dev/null 2>&1; then VARIANTS+=(ctranslate2-cuda); fi
56+
VARIANTS+=(ctranslate2-cpu)
5757
;;
5858
MINGW*|CYGWIN*|MSYS*)
5959
# CUDA on Windows only ships when self-hosted GPU runners exist; the
6060
# workflow gates this on `ENABLE_CUDA`.
61-
VARIANTS+=(cpu)
61+
VARIANTS+=(ctranslate2-cpu)
6262
;;
63-
*) VARIANTS+=(cpu) ;;
63+
*) VARIANTS+=(ctranslate2-cpu) ;;
6464
esac
6565
fi
6666

6767
if [[ "${CPU_ONLY}" -eq 1 ]]; then
68-
VARIANTS=(cpu)
68+
VARIANTS=(ctranslate2-cpu)
6969
fi
7070

7171
echo "Variants to build: ${VARIANTS[*]:-none}"

0 commit comments

Comments
 (0)