Repository navigation
Commit a26f3d3
committed
fix(onnx): give SOURCE_COMMIT a use, instead of a lint suppression
Lint caught it and was right: `SOURCE_COMMIT` existed only to be read out
of this file by a `sed` in the workflow, which makes it dead as far as
this module is concerned and fragile as a design — nothing in the file
explains why it cannot be deleted.
It now prints when the fetched artifact is one we built (`spec.baseUrl`
set):
built here from microsoft/onnxruntime@df2ba1cf…
which is the line somebody wants when the binary no longer carries
Microsoft's name and they are trying to work out what it came from. The
upstream path is unchanged and prints nothing extra, because for an
upstream artifact the URL already says.
Exercised, not assumed: `node scripts/fetch-onnxruntime.mjs --force`
downloads, verifies and vendors as before, exit 0, and the new line stays
quiet because the upstream entry has no `baseUrl`.1 parent 06937ca commit a26f3d3
1 file changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
325 | 325 | | |
326 | 326 | | |
327 | 327 | | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
328 | 335 | | |
329 | 336 | | |
330 | 337 | | |
| |||
0 commit comments