fix(delete): keep a project's recordings while another project file does not parse

A project that fails to parse is left out of the list the delete checks for
other users of a recording, so a take it shares could be trashed with the
project being deleted. While any project file is unreadable, the dialog
offers no Trash and says why, and the delete itself refuses to remove
recordings.

Author: marcgabe15

electron/ai-edition/document-service.ts

@@ -386,11 +386,20 @@ export class DocumentService {
 
 	/** Every project that parses, unrelinked and unannounced: a listing, not an open. */
 	async readAllProjects(): Promise<AxcutDocument[]> {
+		return (await this.readAllProjectsReport()).documents;
+	}
+
+	/**
+	 * `readAllProjects`, plus the project files it skipped. A caller deciding whether no project
+	 * uses a file needs those: a project that does not parse may still be using it.
+	 */
+	async readAllProjectsReport(): Promise<{ documents: AxcutDocument[]; unreadable: string[] }> {
 		await this.ensureProjectsDir();
 		const entries = await fs.readdir(this.projectsRoot);
 		// ensureProjectsDir (above) already migrated any legacy `.axcut` files.
 		const projectFiles = entries.filter((name) => name.endsWith(PROJECT_FILE_EXTENSION));
 		const documents: AxcutDocument[] = [];
+		const unreadable: string[] = [];
 		for (const name of projectFiles) {
 			const filePath = path.join(this.projectsRoot, name);
 			try {
@@ -399,9 +408,10 @@ export class DocumentService {
 				// ponytail: skip unreadable files rather than failing the whole list.
 				// A future migration pass can recover them.
 				console.warn(`[ai-edition] failed to read ${filePath}:`, error);
+				unreadable.push(filePath);
 			}
 		}
-		return documents;
+		return { documents, unreadable };
 	}
 
 	/**

electron/ai-edition/project-recordings.test.ts

@@ -50,9 +50,11 @@ describe("project recordings", () => {
 		await touch(path.join(recordingsDir, "recording-123.mp4"));
 		const id = await projectWith("Mine", video);
 
-		const { owned, keptFor } = await findProjectRecordings(id, await documents.readAllProjects(), [
-			recordingsDir,
-		]);
+		const { owned, keptFor } = await findProjectRecordings(
+			id,
+			await documents.readAllProjectsReport(),
+			[recordingsDir],
+		);
 
 		expect(owned).toHaveLength(1);
 		expect(owned[0].files.sort()).toEqual([video, ...companions].sort());
@@ -66,19 +68,52 @@ describe("project recordings", () => {
 		const id = await projectWith("Mine", shared, own);
 		await projectWith("Demo v2", shared);
 
-		const { owned, keptFor } = await findProjectRecordings(id, await documents.readAllProjects(), [
-			recordingsDir,
-		]);
+		const { owned, keptFor } = await findProjectRecordings(
+			id,
+			await documents.readAllProjectsReport(),
+			[recordingsDir],
+		);
 
 		expect(owned.map((set) => set.stem)).toEqual(["recording-2"]);
 		expect(keptFor).toEqual(["Demo v2"]);
 	});
 
+	it("keeps every recording while a project file does not parse", async () => {
+		const video = await touch(path.join(recordingsDir, "recording-9.mp4"));
+		const id = await projectWith("Mine", video);
+		// Could be a project using recording-9: a newer schema, or a save cut short.
+		await touch(path.join(root, "projects", "broken.openscreen"), "{ not json");
+
+		const { owned, keptFor, unreadable } = await findProjectRecordings(
+			id,
+			await documents.readAllProjectsReport(),
+			[recordingsDir],
+		);
+
+		expect(owned).toEqual([]);
+		expect(keptFor).toEqual([]);
+		expect(unreadable).toBe(1);
+	});
+
+	it("reports no unreadable projects when it has no recordings to keep", async () => {
+		const imported = await touch(path.join(elsewhere, "clip.mp4"));
+		const id = await projectWith("Imported", imported);
+		await touch(path.join(root, "projects", "broken.openscreen"), "{ not json");
+
+		const { unreadable } = await findProjectRecordings(
+			id,
+			await documents.readAllProjectsReport(),
+			[recordingsDir],
+		);
+
+		expect(unreadable).toBe(0);
+	});
+
 	it("never owns a video outside the recordings folders", async () => {
 		const imported = await touch(path.join(elsewhere, "recording-5.mp4"));
 		const id = await projectWith("Imported", imported);
 
-		const { owned } = await findProjectRecordings(id, await documents.readAllProjects(), [
+		const { owned } = await findProjectRecordings(id, await documents.readAllProjectsReport(), [
 			recordingsDir,
 		]);
 
@@ -89,7 +124,7 @@ describe("project recordings", () => {
 		const video = await touch(path.join(recordingsDir, "recording-7.mp4"));
 		const cursor = await touch(`${video}.cursor.json`);
 		const id = await projectWith("Mine", video);
-		const { owned } = await findProjectRecordings(id, await documents.readAllProjects(), [
+		const { owned } = await findProjectRecordings(id, await documents.readAllProjectsReport(), [
 			recordingsDir,
 		]);
 

electron/ai-edition/project-recordings.ts

@@ -16,6 +16,11 @@ export interface ProjectRecordings {
 	owned: RecordingSet[];
 	/** Titles of the other projects that use some of this project's recordings. */
 	keptFor: string[];
+	/**
+	 * Project files that did not parse. Any of them may use these recordings, so while there
+	 * are some the project owns none: its recordings are all kept.
+	 */
+	unreadable: number;
 }
 
 export type RecordingsDisposal = "keep" | "trash" | "permanent";
@@ -83,13 +88,17 @@ async function readRecordingSet(key: string): Promise<RecordingSet | null> {
  */
 export async function findProjectRecordings(
 	projectId: string,
-	documents: readonly AxcutDocument[],
+	projects: { documents: readonly AxcutDocument[]; unreadable: readonly string[] },
 	recordingsDirs: readonly string[],
 ): Promise<ProjectRecordings> {
+	const { documents } = projects;
 	const target = documents.find((doc) => doc.project.id === projectId);
-	if (!target) return { owned: [], keptFor: [] };
+	if (!target) return { owned: [], keptFor: [], unreadable: 0 };
 
 	const keys = documentRecordingKeys(target, recordingsDirs);
+	if (keys.size > 0 && projects.unreadable.length > 0) {
+		return { owned: [], keptFor: [], unreadable: projects.unreadable.length };
+	}
 	const keptFor = new Set<string>();
 	for (const doc of documents) {
 		if (doc.project.id === projectId) continue;
@@ -107,7 +116,7 @@ export async function findProjectRecordings(
 		const set = await readRecordingSet(key);
 		if (set) owned.push(set);
 	}
-	return { owned, keptFor: [...keptFor] };
+	return { owned, keptFor: [...keptFor], unreadable: 0 };
 }
 
 /** Throws on the first file that cannot be removed, so a failed trash can be retried permanently. */

electron/native-bridge/services/aiEditionService.deleteRecordings.test.ts

@@ -57,6 +57,7 @@ describe("AiEditionService — deleting a project's recordings", () => {
 			count: 1,
 			sizeBytes: 5 + 2,
 			keptFor: [],
+			unreadable: 0,
 		});
 	});
 
@@ -78,6 +79,17 @@ describe("AiEditionService — deleting a project's recordings", () => {
 		).toBeNull();
 	});
 
+	it("deletes nothing when a project file stopped parsing after the dialog asked", async () => {
+		await fs.writeFile(path.join(root, "projects", "broken.openscreen"), "{ not json");
+
+		await expect(service().deleteProject(projectId, "trash")).resolves.toMatchObject({
+			success: false,
+		});
+		expect(trashItem).not.toHaveBeenCalled();
+		await expect(fs.access(video)).resolves.toBeUndefined();
+		await expect(documents.getProject(projectId)).resolves.toBeDefined();
+	});
+
 	it("keeps everything when the Trash refuses, then deletes permanently on request", async () => {
 		trashItem.mockRejectedValueOnce(new Error("no trash on this filesystem"));
 

electron/native-bridge/services/aiEditionService.ts

@@ -158,25 +158,27 @@ export class AiEditionService {
 
 	async projectRecordings(projectId: string): Promise<AiEditionProjectRecordingsResult> {
 		const recordings = this.options.recordings;
-		if (!recordings) return { success: true, count: 0, sizeBytes: 0, keptFor: [] };
+		if (!recordings) return { success: true, count: 0, sizeBytes: 0, keptFor: [], unreadable: 0 };
 		try {
-			const { owned, keptFor } = await findProjectRecordings(
+			const { owned, keptFor, unreadable } = await findProjectRecordings(
 				projectId,
-				await this.options.documents.readAllProjects(),
+				await this.options.documents.readAllProjectsReport(),
 				recordings.dirs(),
 			);
 			return {
 				success: true,
 				count: owned.length,
 				sizeBytes: owned.reduce((sum, set) => sum + set.sizeBytes, 0),
 				keptFor,
+				unreadable,
 			};
 		} catch (error) {
 			return {
 				success: false,
 				count: 0,
 				sizeBytes: 0,
 				keptFor: [],
+				unreadable: 0,
 				error: error instanceof Error ? error.message : String(error),
 			};
 		}
@@ -191,11 +193,19 @@ export class AiEditionService {
 		// the user can retry, instead of leaving takes that nothing points at any more.
 		if (disposal !== "keep" && recordings) {
 			try {
-				const { owned } = await findProjectRecordings(
+				const { owned, unreadable } = await findProjectRecordings(
 					projectId,
-					await this.options.documents.readAllProjects(),
+					await this.options.documents.readAllProjectsReport(),
 					recordings.dirs(),
 				);
+				// A project file broke since the dialog asked: deleting the project alone would
+				// quietly drop the recordings the user chose to remove, so delete nothing.
+				if (unreadable > 0) {
+					return {
+						success: false,
+						error: `${unreadable} project file(s) could not be read, so recordings they may use were not deleted`,
+					};
+				}
 				await removeRecordingSets(owned, disposal, recordings.trashItem);
 				await forgetMediaLinks(
 					recordings.registryDir(),

src/components/ai-edition/Modals.tsx

@@ -365,6 +365,17 @@ export function OpenProjectModal({
 												})}
 											</div>
 										) : null}
+										{!trashFailed && recordings && recordings.unreadable > 0 ? (
+											<div
+												style={{
+													font: "400 12px/1.4 var(--font-body)",
+													color: "var(--muted)",
+													marginTop: 4,
+												}}
+											>
+												{t("openProjectDialog.recordingsKeptUnreadable")}
+											</div>
+										) : null}
 									</div>
 									<button
 										type="button"

src/components/ai-edition/OpenProjectModal.test.tsx

@@ -25,6 +25,7 @@ const noRecordings: AiEditionProjectRecordingsResult = {
 	count: 0,
 	sizeBytes: 0,
 	keptFor: [],
+	unreadable: 0,
 };
 
 function renderModal(
@@ -57,6 +58,7 @@ const ownRecordings: AiEditionProjectRecordingsResult = {
 	count: 2,
 	sizeBytes: 24 * 1024 * 1024,
 	keptFor: [],
+	unreadable: 0,
 };
 
 describe("OpenProjectModal delete", () => {
@@ -118,6 +120,17 @@ describe("OpenProjectModal delete", () => {
 		expect(await screen.findByText(/used by Demo v2 are kept/i)).toBeInTheDocument();
 	});
 
+	it("offers no Trash and says why when a project file could not be read", async () => {
+		const { onDelete } = renderModal({ recordings: { ...noRecordings, unreadable: 1 } });
+
+		fireEvent.click(screen.getAllByRole("button", { name: /delete project/i })[0]);
+
+		expect(await screen.findByText(/couldn't be read/i)).toBeInTheDocument();
+		expect(screen.queryByRole("button", { name: /move its recordings/i })).not.toBeInTheDocument();
+		fireEvent.click(screen.getByRole("button", { name: /^delete$/i }));
+		await waitFor(() => expect(onDelete).toHaveBeenCalledWith("proj_one", "keep"));
+	});
+
 	it("asks to delete permanently when the Trash refuses", async () => {
 		const { onDelete } = renderModal({
 			recordings: ownRecordings,

src/i18n/locales/ar/editor.json

@@ -342,6 +342,7 @@
 		"alsoTrash": "نقل تسجيلاته أيضًا إلى سلة المهملات ({{size}})",
 		"alsoRecycle": "نقل تسجيلاته أيضًا إلى سلة المحذوفات ({{size}})",
 		"recordingsKeptFor": "يتم الاحتفاظ بالتسجيلات التي يستخدمها {{projects}}.",
+		"recordingsKeptUnreadable": "تعذّرت قراءة بعض المشاريع، لذا يتم الاحتفاظ بتسجيلات هذا المشروع.",
 		"trashFailed": "تعذّر نقل التسجيلات إلى سلة المهملات. هل تريد حذفها نهائيًا؟",
 		"recycleFailed": "تعذّر نقل التسجيلات إلى سلة المحذوفات. هل تريد حذفها نهائيًا؟",
 		"deletePermanently": "حذف نهائي"

src/i18n/locales/cs/editor.json

@@ -342,6 +342,7 @@
 		"alsoTrash": "Přesunout také jeho nahrávky do koše ({{size}})",
 		"alsoRecycle": "Přesunout také jeho nahrávky do koše ({{size}})",
 		"recordingsKeptFor": "Nahrávky používané projektem {{projects}} zůstanou zachovány.",
+		"recordingsKeptUnreadable": "Některé projekty nešlo přečíst, proto nahrávky tohoto projektu zůstanou zachovány.",
 		"trashFailed": "Nahrávky se nepodařilo přesunout do koše. Smazat je trvale?",
 		"recycleFailed": "Nahrávky se nepodařilo přesunout do koše. Smazat je trvale?",
 		"deletePermanently": "Smazat trvale"

src/i18n/locales/de/editor.json

@@ -342,6 +342,7 @@
 		"alsoTrash": "Auch die Aufnahmen in den Papierkorb legen ({{size}})",
 		"alsoRecycle": "Auch die Aufnahmen in den Papierkorb verschieben ({{size}})",
 		"recordingsKeptFor": "Aufnahmen, die {{projects}} verwendet, bleiben erhalten.",
+		"recordingsKeptUnreadable": "Einige Projekte konnten nicht gelesen werden, daher bleiben die Aufnahmen dieses Projekts erhalten.",
 		"trashFailed": "Die Aufnahmen konnten nicht in den Papierkorb gelegt werden. Endgültig löschen?",
 		"recycleFailed": "Die Aufnahmen konnten nicht in den Papierkorb verschoben werden. Endgültig löschen?",
 		"deletePermanently": "Endgültig löschen"