Skip to content

Commit 4c84d26

Browse files
committed
REST: Fix bug 335 tests
One extra query is necessary for patch/cover endpoints to fetch labels information.
1 parent 6d825b1 commit 4c84d26

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

‎patchwork/api/cover.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,10 @@ class CoverList(ListAPIView):
114114
def get_queryset(self):
115115
return (
116116
Cover.objects.all()
117-
.prefetch_related('series__project')
117+
.prefetch_related(
118+
'series__project',
119+
'labels',
120+
)
118121
.select_related('project', 'submitter', 'series')
119122
.defer('content', 'headers')
120123
)

‎patchwork/tests/unit/api/test_cover.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ def test_list_bug_335(self):
153153
series = create_series()
154154
create_covers(5, series=series)
155155

156-
with self.assertNumQueries(3):
156+
with self.assertNumQueries(4):
157157
self.client.get(self.api_url())
158158

159159
@utils.store_samples('cover-detail')

‎patchwork/tests/unit/api/test_patch.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ def test_list_bug_335(self):
254254
series = create_series()
255255
create_patches(5, series=series)
256256

257-
with self.assertNumQueries(5):
257+
with self.assertNumQueries(6):
258258
self.client.get(self.api_url())
259259

260260
@utils.store_samples('patch-detail')

0 commit comments

Comments
 (0)