Skip to content

Commit c0eb348

Browse files
committed
api: Reuse embedded serializers
Reuse each bound field's serializer instead of rebuilding its fields for every related object. Signed-off-by: Stephen Finucane <stephen@that.guru> Assisted-by: OpenAI gpt-6.1-sol (via pi)
1 parent e9cbf1a commit c0eb348

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

‎patchwork/api/embedded.py‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
from collections import OrderedDict
1313

14+
from django.utils.functional import cached_property
15+
1416
from rest_framework.serializers import CharField
1517
from rest_framework.serializers import PrimaryKeyRelatedField
1618
from rest_framework.serializers import SerializerMethodField
@@ -49,8 +51,14 @@ def get_choices(self, cutoff=None):
4951
[(item.pk, self.display_value(item)) for item in queryset]
5052
)
5153

54+
@cached_property
55+
def serializer(self):
56+
# Fields are bound to a serializer for one request. Reuse the embedded
57+
# serializer instead of rebuilding its fields for every related object.
58+
return self._Serializer(context=self.context)
59+
5260
def to_representation(self, data):
53-
return self._Serializer(context=self.context).to_representation(data)
61+
return self.serializer.to_representation(data)
5462

5563

5664
class MboxMixin(BaseHyperlinkedModelSerializer):

0 commit comments

Comments
 (0)