Skip to content

ref(codeowners): Point mobile docs reviewers at the new SDK teams - #20199

Merged
christophaigner merged 2 commits into
masterfrom
chore/mobile-sdk-team-codeowners
Oct 27, 2026
Merged

christophaigner merged 2 commits into
masterfrom
chore/mobile-sdk-team-codeowners

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

DESCRIBE YOUR PR

The mobile team was split into per-platform SDK teams. The commented entries in .github/CODEOWNERS are used by scripts/pr-reviewer-assignment.mjs to request specialist reviewers, so they still point at the legacy teams.

  • /docs/platforms/android/ → @getsentry/team-mobile-android-sdk (was team-mobile-core)
  • /docs/platforms/apple/ → @getsentry/team-mobile-apple-sdk (was team-mobile-core)
  • /docs/platforms/dart/, /docs/platforms/react-native/, /docs/platforms/javascript/guides/cordova/ → @getsentry/team-mobile-cross-platform-sdks (was team-mobile-cross-platform)

The reviewer-assignment test fixture used team-mobile-core as its example slug; it now uses team-mobile-android-sdk, so the test no longer refers to a team that will be removed. No logic changes.

Verified locally: vitest run scripts/pr-reviewer-assignment.test.mjs (23 passed), Prettier clean.

IS YOUR CHANGE URGENT?

  • Urgent deadline (GA date, etc.): YYYY-MM-DD
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

via Chris Aigner.

--

View Junior Session [Sentry]

The mobile team was split into per-platform SDK teams. Update the
commented CODEOWNERS entries used by PR reviewer assignment so Android,
Apple, and cross-platform docs request the matching team, and update
the reviewer-assignment test fixture to use a current team slug.

Co-Authored-By: Chris Aigner <christoph.aigner@sentry.io>
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
develop-docs Ready Ready Preview Oct 27, 2026 11:05am UTC
sentry-docs Ready Ready Preview Oct 27, 2026 11:05am UTC

Request Review

@github-actions github-actions Bot added the Priority: Normal Docs review has no urgent deadline label Oct 23, 2026
@christophaigner
christophaigner marked this pull request as ready for review October 23, 2026 11:44
@christophaigner
christophaigner enabled auto-merge (squash) October 23, 2026 11:44
@christophaigner christophaigner self-assigned this Oct 23, 2026
@cursor

cursor Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

The plan checks specialist reviewer requests on later pull requests that touch the remapped platform docs. It also checks reviewer assignment workflow failures. An issue escalates when the workflow fails or those pull requests still request the old teams.

Not monitored: no services

Mention @change-monitor in a comment to update the plan.

Plan

What changed

Pull requests that change Android, Apple, Dart, React Native, or Cordova docs now request new SDK teams. They request team-mobile-android-sdk, team-mobile-apple-sdk, or team-mobile-cross-platform-sdks instead of the old teams. No catalog service must deploy before this is live. The assignment workflow reads commented CODEOWNERS from the default branch. The test fixture slug change does not change assignment logic.

Path New team slug Old team slug
/docs/platforms/android/ team-mobile-android-sdk team-mobile-core
/docs/platforms/apple/ team-mobile-apple-sdk team-mobile-core
/docs/platforms/dart/ team-mobile-cross-platform-sdks team-mobile-cross-platform
/docs/platforms/react-native/ team-mobile-cross-platform-sdks team-mobile-cross-platform
/docs/platforms/javascript/guides/cordova/ team-mobile-cross-platform-sdks team-mobile-cross-platform

Risk

If a new team slug is invalid, GitHub rejects the reviewer request and the workflow fails. Specialists then do not review those platform docs pull requests. A wrong path-to-team map sends review to the wrong specialists. Sibling commented CODEOWNERS paths could lose their current teams if parsing broke. This patch does not change parsing.

Intended effect

The intended effect is the new team slugs appearing as requested reviewers. Absence of errors is not enough. There is no queryable production counter. The assignment script writes JSON only to workflow logs.

absent means later pull requests that change those paths still request the old teams. It also looks absent when those pull requests request no specialist team. confirmed means those pull requests request the new SDK teams as mapped above. Connected telemetry cannot fill this axis. See Not observable.

Regression watch

This patch can break reviewer assignment, not public docs pages. The symptom on-call would see is a failed reviewer assignment workflow run. A second break is a missing or wrong specialist request on a sibling CODEOWNERS path that this patch did not retarget.

Do not treat public docs errors or latency as this change. Connected telemetry has no measured baseline for the workflow or for reviewer requests. See Not observable.

Not observable

GitHub reviewer lists for pull requests that touch the remapped paths. There is no connected source for that population, so there is no pre-ship rate. Reviewer assignment workflow failure rate. GitHub API errors on requested_reviewers for the new team slugs. Sibling specialist requests on unchanged CODEOWNERS paths.

@christophaigner
christophaigner merged commit f72a9c7 into master Oct 27, 2026
26 checks passed
@christophaigner
christophaigner deleted the chore/mobile-sdk-team-codeowners branch October 27, 2026 15:11

This branch was successfully deployed

2 active deployments
Preview – sentry-docs — 2ed407ce Deployed Oct 27, 2026 by vercel[bot]
Preview – develop-docs — 2ed407ce Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Normal Docs review has no urgent deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants