Repository navigation
ref(codeowners): Point mobile docs reviewers at the new SDK teams - #20199
Conversation
The mobile team was split into per-platform SDK teams. Update the commented CODEOWNERS entries used by PR reviewer assignment so Android, Apple, and cross-platform docs request the matching team, and update the reviewer-assignment test fixture to use a current team slug. Co-Authored-By: Chris Aigner <christoph.aigner@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The plan checks specialist reviewer requests on later pull requests that touch the remapped platform docs. It also checks reviewer assignment workflow failures. An issue escalates when the workflow fails or those pull requests still request the old teams. Not monitored: no services Mention PlanWhat changedPull requests that change Android, Apple, Dart, React Native, or Cordova docs now request new SDK teams. They request team-mobile-android-sdk, team-mobile-apple-sdk, or team-mobile-cross-platform-sdks instead of the old teams. No catalog service must deploy before this is live. The assignment workflow reads commented CODEOWNERS from the default branch. The test fixture slug change does not change assignment logic.
RiskIf a new team slug is invalid, GitHub rejects the reviewer request and the workflow fails. Specialists then do not review those platform docs pull requests. A wrong path-to-team map sends review to the wrong specialists. Sibling commented CODEOWNERS paths could lose their current teams if parsing broke. This patch does not change parsing. Intended effectThe intended effect is the new team slugs appearing as requested reviewers. Absence of errors is not enough. There is no queryable production counter. The assignment script writes JSON only to workflow logs.
Regression watchThis patch can break reviewer assignment, not public docs pages. The symptom on-call would see is a failed reviewer assignment workflow run. A second break is a missing or wrong specialist request on a sibling CODEOWNERS path that this patch did not retarget. Do not treat public docs errors or latency as this change. Connected telemetry has no measured baseline for the workflow or for reviewer requests. See Not observable. Not observableGitHub reviewer lists for pull requests that touch the remapped paths. There is no connected source for that population, so there is no pre-ship rate. Reviewer assignment workflow failure rate. GitHub API errors on |
DESCRIBE YOUR PR
The mobile team was split into per-platform SDK teams. The commented entries in
.github/CODEOWNERSare used byscripts/pr-reviewer-assignment.mjsto request specialist reviewers, so they still point at the legacy teams./docs/platforms/android/→@getsentry/team-mobile-android-sdk(wasteam-mobile-core)/docs/platforms/apple/→@getsentry/team-mobile-apple-sdk(wasteam-mobile-core)/docs/platforms/dart/,/docs/platforms/react-native/,/docs/platforms/javascript/guides/cordova/→@getsentry/team-mobile-cross-platform-sdks(wasteam-mobile-cross-platform)The reviewer-assignment test fixture used
team-mobile-coreas its example slug; it now usesteam-mobile-android-sdk, so the test no longer refers to a team that will be removed. No logic changes.Verified locally:
vitest run scripts/pr-reviewer-assignment.test.mjs(23 passed), Prettier clean.IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST
via Chris Aigner.
--
View Junior Session [Sentry]