From b354dd27b1ccd43c4c9e210ba389638f59a54a2d Mon Sep 17 00:00:00 2001 From: "sentry-junior[bot]" <264270552+sentry-junior[bot]@users.noreply.github.com> Date: Fri, 23 Oct 2026 11:39:44 +0000 Subject: [PATCH] ref(codeowners): Point mobile docs reviewers at the new SDK teams The mobile team was split into per-platform SDK teams. Update the commented CODEOWNERS entries used by PR reviewer assignment so Android, Apple, and cross-platform docs request the matching team, and update the reviewer-assignment test fixture to use a current team slug. Co-Authored-By: Chris Aigner --- .github/CODEOWNERS | 10 +++++----- scripts/pr-reviewer-assignment.test.mjs | 12 +++++++----- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index bc7683093e93a..1e0e19c4bf064 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -7,11 +7,11 @@ # Codeowners listed below are used as a reference for the Sentry team to know who to contact for a given area of the codebase. -# /docs/platforms/android/ @getsentry/team-mobile-core -# /docs/platforms/apple/ @getsentry/team-mobile-core -# /docs/platforms/dart/ @getsentry/team-mobile-cross-platform -# /docs/platforms/react-native/ @getsentry/team-mobile-cross-platform -# /docs/platforms/javascript/guides/cordova/ @getsentry/team-mobile-cross-platform +# /docs/platforms/android/ @getsentry/team-mobile-android-sdk +# /docs/platforms/apple/ @getsentry/team-mobile-apple-sdk +# /docs/platforms/dart/ @getsentry/team-mobile-cross-platform-sdks +# /docs/platforms/react-native/ @getsentry/team-mobile-cross-platform-sdks +# /docs/platforms/javascript/guides/cordova/ @getsentry/team-mobile-cross-platform-sdks # /docs/platforms/godot/ @getsentry/gdx # /docs/platforms/nintendo-switch/ @getsentry/gdx diff --git a/scripts/pr-reviewer-assignment.test.mjs b/scripts/pr-reviewer-assignment.test.mjs index 5df04173c03e8..6b34f666f1b73 100644 --- a/scripts/pr-reviewer-assignment.test.mjs +++ b/scripts/pr-reviewer-assignment.test.mjs @@ -10,7 +10,7 @@ import { const CODEOWNERS = ` # A documentation comment without reviewers **/vercel.json @getsentry/security -# /docs/platforms/android/ @getsentry/team-mobile-core +# /docs/platforms/android/ @getsentry/team-mobile-android-sdk # /docs/platforms/native/ @getsentry/product-owners-sdks-native # /docs/product/explore/session-replay/web @getsentry/replay-sdk-web @getsentry/replay-frontend # /includes/session-replay-web-report-bug.mdx @getsentry/replay-sdk-web @@ -22,7 +22,9 @@ describe('parseCommentedCodeowners', () => { expect(parseCommentedCodeowners(CODEOWNERS)).toEqual([ { pattern: '/docs/platforms/android/', - reviewers: [{type: 'team', organization: 'getsentry', slug: 'team-mobile-core'}], + reviewers: [ + {type: 'team', organization: 'getsentry', slug: 'team-mobile-android-sdk'}, + ], }, { pattern: '/docs/platforms/native/', @@ -112,7 +114,7 @@ describe('collectSpecialistReviewers', () => { 'getsentry' ); - expect(result.teams).toEqual(['team-mobile-core']); + expect(result.teams).toEqual(['team-mobile-android-sdk']); }); it('ignores teams from another organization', () => { @@ -135,7 +137,7 @@ describe('buildReviewerPlan', () => { requestDocsReview: true, }); - expect(result.teams).toEqual(['docs', 'team-mobile-core']); + expect(result.teams).toEqual(['docs', 'team-mobile-android-sdk']); }); it('skips existing requests and the pull request author', () => { @@ -146,7 +148,7 @@ describe('buildReviewerPlan', () => { 'docs/platforms/android/index.mdx', ], repositoryOwner: 'getsentry', - requestedTeams: [{slug: 'team-mobile-core'}], + requestedTeams: [{slug: 'team-mobile-android-sdk'}], excludedUsers: ['ryan953'], requestDocsReview: true, });