Skip to content

ref(codeowners): Point mobile docs reviewers at the new SDK teams #20199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christophaigner merged 2 commits into from
Oct 27, 2026
Merged

ref(codeowners): Point mobile docs reviewers at the new SDK teams #20199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b354dd2
ref(codeowners): Point mobile docs reviewers at the new SDK teams
sentry-junior[bot] Oct 23, 2026
2ed407c
Merge branch 'master' into chore/mobile-sdk-team-codeowners
christophaigner Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@

# Codeowners listed below are used as a reference for the Sentry team to know who to contact for a given area of the codebase.

# /docs/platforms/android/ @getsentry/team-mobile-core
# /docs/platforms/apple/ @getsentry/team-mobile-core
# /docs/platforms/dart/ @getsentry/team-mobile-cross-platform
# /docs/platforms/react-native/ @getsentry/team-mobile-cross-platform
# /docs/platforms/javascript/guides/cordova/ @getsentry/team-mobile-cross-platform
# /docs/platforms/android/ @getsentry/team-mobile-android-sdk
# /docs/platforms/apple/ @getsentry/team-mobile-apple-sdk
# /docs/platforms/dart/ @getsentry/team-mobile-cross-platform-sdks
# /docs/platforms/react-native/ @getsentry/team-mobile-cross-platform-sdks
# /docs/platforms/javascript/guides/cordova/ @getsentry/team-mobile-cross-platform-sdks

# /docs/platforms/godot/ @getsentry/gdx
# /docs/platforms/nintendo-switch/ @getsentry/gdx
Expand Down
12 changes: 7 additions & 5 deletions scripts/pr-reviewer-assignment.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
const CODEOWNERS = `
# A documentation comment without reviewers
**/vercel.json @getsentry/security
# /docs/platforms/android/ @getsentry/team-mobile-core
# /docs/platforms/android/ @getsentry/team-mobile-android-sdk
# /docs/platforms/native/ @getsentry/product-owners-sdks-native
# /docs/product/explore/session-replay/web @getsentry/replay-sdk-web @getsentry/replay-frontend
# /includes/session-replay-web-report-bug.mdx @getsentry/replay-sdk-web
Expand All @@ -22,7 +22,9 @@ describe('parseCommentedCodeowners', () => {
expect(parseCommentedCodeowners(CODEOWNERS)).toEqual([
{
pattern: '/docs/platforms/android/',
reviewers: [{type: 'team', organization: 'getsentry', slug: 'team-mobile-core'}],
reviewers: [
{type: 'team', organization: 'getsentry', slug: 'team-mobile-android-sdk'},
],
},
{
pattern: '/docs/platforms/native/',
Expand Down Expand Up @@ -112,7 +114,7 @@ describe('collectSpecialistReviewers', () => {
'getsentry'
);

expect(result.teams).toEqual(['team-mobile-core']);
expect(result.teams).toEqual(['team-mobile-android-sdk']);
});

it('ignores teams from another organization', () => {
Expand All @@ -135,7 +137,7 @@ describe('buildReviewerPlan', () => {
requestDocsReview: true,
});

expect(result.teams).toEqual(['docs', 'team-mobile-core']);
expect(result.teams).toEqual(['docs', 'team-mobile-android-sdk']);
});

it('skips existing requests and the pull request author', () => {
Expand All @@ -146,7 +148,7 @@ describe('buildReviewerPlan', () => {
'docs/platforms/android/index.mdx',
],
repositoryOwner: 'getsentry',
requestedTeams: [{slug: 'team-mobile-core'}],
requestedTeams: [{slug: 'team-mobile-android-sdk'}],
excludedUsers: ['ryan953'],
requestDocsReview: true,
});
Expand Down
Loading