Repository navigation
Conversation
fixes 17367
|
@a-hariti is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
|
Please update the IS YOUR CHANGE URGENT? section of the PR description:
This information helps the Docs team prioritize your review. |
|
The plan checks image transfer size, LCP, CLS, and client errors. An issue escalates when CLS rises, LCP rises, or client errors rise. Wide images should transfer fewer bytes after deploy. Services: Mention PlanWhat changedLocal markdown images wider than 900 pixels now encode width 900 and a scaled height. next/image builds srcset from that hash so wide images request smaller files. sentry-docs and develop-docs must deploy before this change is live. Both sites share this plugin under src. RiskA wrong scaled height may raise CLS on pages with a wide image. Invalid dimensions may cause next/image to fail and hide the figure. Both sites ship the same plugin so an error reaches both. Intended effectWide images should transfer fewer bytes. Absent looks like p99 image transfer size holding near 85 KB. Pages can still load while that size does not fall.
Fleet p95 stayed at 5 KB in the 24h and 48h windows. That value will not show this change. Use p99. Regression watchA wrong height shows as higher CLS. A next/image failure shows as more client errors. A bad srcset may also raise LCP. Traces sample 30 percent of pageloads. Client errors are not sampled the same way. Compare the ratio to this band. Do not treat it as a user percent.
If CLS rises, inspect wide figures for a bad aspect ratio. If client errors rise, inspect next/image failures on DocImage. Not observableSentry does not split image spans by intrinsic width. The pre-ship byte rate for images wider than 900 pixels is unknown. Fleet p50 image size is 814 bytes and p75 is 1164-1173 bytes. Those values will not show this change. Prior-day p99 image transfer size was not measured. Prior-day client errors for develop-docs were not measured. Image blur from upscaling has no signal. |
|
@sergical Please allow deployment and take a look 👀 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Checked the preview: no visible change, here or on prod. esbuild's file loader drops Pushed a fix (234c36b): a small remark step after |
esbuild's file loader drops the query and hash from image imports, so the `#WxH` size added by remark-image-processing never reached DocImage and every docs image rendered as a plain <img> instead of next/image. Add remarkImageSizeToSrc after remark-mdx-images to append the size hash to the imported src expression, so the capped width takes effect. Co-authored-by: Claude <claude@anthropic.com>
|
Deployment failed for project develop-docs with the following error: |
|
Deployment failed for project sentry-docs with the following error: |
This reverts commit 234c36b. Routing every docs image through next/image shrinks screenshots on 2x screens and in the lightbox, and needs a longer minimumCacheTTL to avoid repeat transformation costs. Reverting until the PR author picks a direction. Co-authored-by: Claude <claude@anthropic.com>
|
Reverted my fix (4b47abe). Routing images through
Options:
@a-hariti which way do you want to go? |
|
where is this configured?
the options
|
|
@a-hariti https://nextjs.org/docs/app/api-reference/file-conventions/public-folder#caching its the default for public images up to you! |
|
I think |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2474c23. Configure here.
|
Please authorize the deployment @sergical |

fixes #17367
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES