Skip to content

build(node): Bump Node to 22 - #20256

Merged
other-geoffrey merged 1 commit into
masterfrom
vuln-3216/node-22
Oct 27, 2026
Merged

other-geoffrey merged 1 commit into
masterfrom
vuln-3216/node-22

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

screenshot-pipeline.yml and update-docs-changelog.yml set up Node 20, which has no fix for CVE-2026-111497 (Brotli) or the eMudhra root update. This moves both to Node 22, which resolves to 22.23.4 and matches the repo's volta pin. Tracked in VULN-3216.

This is a major-line move (20 → 22).

via Geoff Goldsmith.

--

View Junior Session [Sentry]

Co-Authored-By: Geoff Goldsmith <geoff.goldsmith@sentry.io>
@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
develop-docs Ready Ready Preview Oct 27, 2026 2:45pm UTC
sentry-docs Ready Ready Preview Oct 27, 2026 2:45pm UTC

Request Review

@linear-code

linear-code Bot commented Oct 27, 2026

Copy link
Copy Markdown

VULN-3216

@github-actions github-actions Bot added the Priority: Needs Triage The PR description is missing valid priority information label Oct 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Please update the IS YOUR CHANGE URGENT? section of the PR description:

  • Select exactly one option.
  • If you selected an urgent or other deadline, provide the date as YYYY-MM-DD.

This information helps the Docs team prioritize your review.

@cursor

cursor Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

The plan checks Node version on both jobs and job failure. An issue escalates when a job fails during setup, install, or the script. Those jobs run on the next schedule or on a manual run.

Not monitored: no services

Mention @change-monitor in a comment to update the plan.

Plan

What changed

The Screenshot Pipeline job now installs Node 22. The Update Docs Changelog job now installs Node 22. Both jobs used Node 20. No catalog service ships this change. GitHub Actions reads the job files from the default branch after merge. The jobs do not run at deploy time. They run on the Monday schedule or on a manual run. The repo volta pin is already Node 22.23.4. The Screenshot Pipeline script directory is not in this tree.

Risk

Node 22 can fail the Node setup step, npm install, Playwright, ts-node, or the changelog script. A failed Screenshot Pipeline skips screenshot PRs and Linear issues. A failed changelog job leaves the docs changelog include stale. The changelog job merges with admin rights. A bad script run can publish a broken changelog.

Intended effect

Connected telemetry cannot show this change. The intended effect is that the next run of each job reports Node 22 and completes setup. Absent means the job still reports Node 20, or the Node setup step fails. GitHub Actions is not connected, so the executor cannot confirm or deny this effect from telemetry.

Regression watch

This diff can break the two scheduled jobs. The symptom is a failed GitHub Actions run for Screenshot Pipeline or Update Docs Changelog. A later symptom is a stale or broken docs changelog include after a bot merge. Connected telemetry cannot show those job failures. See Not observable.

Not observable

GitHub Actions job conclusion and Node version are not connected. Datadog tools are not available in this session. The Screenshot Pipeline scripts are missing from this tree. This session cannot name a pipeline metric. The pre-ship failure rate for these two jobs is unknown. The executor must record unknown for both axes.

@other-geoffrey
other-geoffrey merged commit f62d4d4 into master Oct 27, 2026
25 checks passed
@other-geoffrey
other-geoffrey deleted the vuln-3216/node-22 branch October 27, 2026 18:03

This branch was successfully deployed

2 active deployments
Preview – sentry-docs — 451869d0 Deployed Oct 27, 2026 by vercel[bot]
Preview – develop-docs — 451869d0 Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Needs Triage The PR description is missing valid priority information

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant