Skip to content

docs(integration-platform): Fix signature verification and verify-install examples - #20303

Merged
mrduncan merged 1 commit into
masterfrom
docs/integration-platform-signature-and-verify-fixes
Oct 29, 2026
Merged

mrduncan merged 1 commit into
masterfrom
docs/integration-platform-signature-and-verify-fixes

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

This fixes three problems in the Integration Platform docs. Each fix was checked against getsentry/sentry source.

  • Signature verification snippets (webhooks.mdx). Both snippets serialized the parsed body again before hashing it. Sentry signs the exact body it sends, which is compact JSON from sentry.utils.json.dumps with (",", ":") separators. Python's default json.dumps adds spaces, so its digest never matches. The Python snippet also passed a str to hmac.new, which raises a TypeError. Both snippets now verify against the raw body, and the JS one uses a constant-time comparison.
  • Missing Sentry-App-Signature docs (ui-components/index.mdx). UI component requests (select options, issue-link create and link, alert-rule-action) send Sentry-App-Signature, not Sentry-Hook-Signature. See _build_headers in src/sentry/sentry_apps/external_requests/*_requester.py. The new "Verifying Requests" section documents that header and two related details:
    • Select option requests are GETs with no body, signed over "".
    • Query parameters aren't covered by the signature.
  • Verify installation request (public-integration.mdx). The PUT example had no Authorization header. SentryAppInstallationPermission (src/sentry/sentry_apps/api/bases/sentryapps.py) only allows this request from the app's own token, so the example as written fails.

Checks

  • Ran both new snippets locally against a body signed the way Sentry signs. Valid signatures pass; tampered or missing ones fail.
  • Ran prettier --check on the changed files. webhooks.mdx and ui-components/index.mdx pass. public-integration.mdx was already failing on master (tabs in the JWT snippet), and this PR leaves that as is.

IS YOUR CHANGE URGENT?

  • Urgent deadline (GA date, etc.): YYYY-MM-DD
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

via matt.duncan.

--

View Junior Session [Sentry]

…tall examples

Verify signatures over the raw request body, document the
Sentry-App-Signature header used by UI component requests, and add the
missing Authorization header to the verify-installation request.

Co-Authored-By: Matt Duncan <matt.duncan@sentry.io>
@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-docs Ready Ready Preview Oct 28, 2026 10:21pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
develop-docs Ignored Ignored Oct 28, 2026 10:21pm UTC

Request Review

@github-actions github-actions Bot added the Priority: Normal Docs review has no urgent deadline label Oct 28, 2026
@mrduncan
mrduncan marked this pull request as ready for review October 28, 2026 22:36
@mrduncan
mrduncan requested a review from a team October 28, 2026 22:36
@cursor

cursor Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Services awaiting deployment · Rollout details

Status Service Environment
⚪ Not deployed yet sentry-docs

Mention @rollout in a comment to update the plan.

@mrduncan
mrduncan merged commit 09ce3a5 into master Oct 29, 2026
34 checks passed
@mrduncan
mrduncan deleted the docs/integration-platform-signature-and-verify-fixes branch October 29, 2026 17:05
@cursor

cursor Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Rollouts can't watch this change after it deploys: every data source for this team needs to be signed in again, so a check has no telemetry to read. Sign in to your data sources, or ask a team admin to.

This branch was successfully deployed

1 active deployment
Preview – sentry-docs — 46a2ad19 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Normal Docs review has no urgent deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants