Skip to content

docs(native): fix snippets and stale statements - #20327

Merged
jpnurmi merged 1 commit into
masterfrom
jpnurmi/fix/native
Oct 29, 2026
Merged

jpnurmi merged 1 commit into
masterfrom
jpnurmi/fix/native

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

DESCRIBE YOUR PR

Some native snippets didn't compile, and a few statements and notes were outdated.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace YYYY-MM-DD with the due date. You can update this information later by editing the PR description.

  • Urgent deadline (GA date, etc.): YYYY-MM-DD
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've supplied a deadline.

Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Some native snippets didn't compile and there were a few statements
that are no longer valid in the latest 0.17 version.

- Pass the missing `options` and `user_data` arguments, drop a
  trailing comma, use the declared `extra_value`, and bind a
  transaction with `sentry_set_transaction_object()` instead of
  `sentry_set_span()`.
- Serialize `uint64` as numbers, accept unsigned log attributes, and
  emit `baggage` alongside `sentry-trace`.
- Note that the `native` backend chains signal handlers.
@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-docs Ready Ready Preview Oct 29, 2026 4:24pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
develop-docs Ignored Ignored Oct 29, 2026 4:24pm UTC

Request Review

@github-actions github-actions Bot added the Priority: Normal Docs review has no urgent deadline label Oct 29, 2026
@codeowner-assignment
codeowner-assignment Bot requested review from a team October 29, 2026 16:20
@cursor

cursor Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Rollouts can't watch this change after it deploys: every data source for this team needs to be signed in again, so a check has no telemetry to read. Sign in to your data sources, or ask a team admin to.

@JoshuaMoelans JoshuaMoelans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 :shipit:

@jpnurmi
jpnurmi merged commit fe999d8 into master Oct 29, 2026
33 of 34 checks passed
@jpnurmi
jpnurmi deleted the jpnurmi/fix/native branch October 29, 2026 18:24

This branch was successfully deployed

1 active deployment
Preview – sentry-docs — e3d66e62 Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Normal Docs review has no urgent deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants