Skip to content

fix: update documentation for solidstart entry point #20330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
isaacs wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: update documentation for solidstart entry point #20330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions docs/platforms/javascript/guides/solidstart/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,12 @@ export default createMiddleware({

Add the Sentry plugin to your build config and register the middleware you just created. On SolidStart 2, add `sentrySolidStart` to `vite.config.ts`. On SolidStart 1, wrap your `app.config.ts` with `withSentry` so that the instrumentation file gets included in your build output.

<Alert>

SDK versions 11.11.0 and later export `withSentry` from `@sentry/solidstart/vite`. On older versions, import it from `@sentry/solidstart`. The root export still works, but it's deprecated and will be removed in the next major version.

</Alert>

```typescript {tabTitle:SolidStart 2} {filename:vite.config.ts} {mdExpandTabs}
import { sentrySolidStart } from "@sentry/solidstart/vite";
import { solidStart } from "@solidjs/start/config";
Expand All @@ -178,7 +184,7 @@ export default defineConfig({
```

```javascript {tabTitle:SolidStart 1} {filename:app.config.ts} {5-15}
import { withSentry } from "@sentry/solidstart";
import { withSentry } from "@sentry/solidstart/vite";
import { defineConfig } from "@solidjs/start/config";

export default defineConfig(
Expand Down Expand Up @@ -283,7 +289,7 @@ export default defineConfig({
```

```TypeScript {tabTitle:SolidStart 1} {filename:app.config.ts}
import { withSentry } from '@sentry/solidstart';
import { withSentry } from '@sentry/solidstart/vite';
import { defineConfig } from '@solidjs/start/config';

export default defineConfig(
Expand Down
4 changes: 2 additions & 2 deletions docs/platforms/javascript/guides/solidstart/install/dynamic-import.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Enable the dynamic `import()` by setting `autoInjectServerSentry`:

```typescript {filename:app.config.ts} {8}
import { defineConfig } from "@solidjs/start/config";
import { withSentry } from "@sentry/solidstart";
import { withSentry } from "@sentry/solidstart/vite";

export default defineConfig(
withSentry(
Expand Down Expand Up @@ -76,7 +76,7 @@ If your serverless function has a custom name, you can override it with `experim

```javascript {filename: app.config.ts} {11}
import { defineConfig } from "@solidjs/start/config";
import { withSentry } from "@sentry/solidstart";
import { withSentry } from "@sentry/solidstart/vite";

export default defineConfig(
withSentry(
Expand Down
2 changes: 1 addition & 1 deletion docs/platforms/javascript/guides/solidstart/install/limited-server-tracing.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Enable the top-level `import` by setting `autoInjectServerSentry`:

```typescript {filename:app.config.ts} {8}
import { defineConfig } from "@solidjs/start/config";
import { withSentry } from "@sentry/solidstart";
import { withSentry } from "@sentry/solidstart/vite";

export default defineConfig(
withSentry(
Expand Down
Loading