Skip to content

fix(aws-lambda): Style layer selects for dark mode #20337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tlq5l wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(aws-lambda): Style layer selects for dark mode #20337

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d52522
fix(aws-lambda): Style layer selects for dark mode
tlq5l Oct 21, 2026
7b5f719
fix(aws-lambda): Cite react-select default colors in layer select CSS
tlq5l Oct 29, 2026
29f9c03
fix(aws-lambda): Cite every react-select default color in layer selec…
tlq5l Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions src/components/lambdaLayerDetailClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ export function LayerDetailClient({
<Select
instanceId="layer-region"
inputId="layer-region"
classNamePrefix="layer-select"
placeholder="Select a region"
isDisabled={isLoading}
options={regionOptions}
Expand All @@ -220,6 +221,7 @@ export function LayerDetailClient({
<Select
instanceId="layer-runtime"
inputId="layer-runtime"
classNamePrefix="layer-select"
placeholder="Runtime compatibility unavailable"
isDisabled={isLoading || !runtimeOptions.length}
options={runtimeOptions}
Expand All @@ -233,6 +235,7 @@ export function LayerDetailClient({
<Select<SelectOption>
instanceId="layer-sdk-version"
inputId="layer-sdk-version"
classNamePrefix="layer-select"
isDisabled={isLoading}
options={sdkVersionOptions}
value={selectedSdkVersionOption}
Expand Down Expand Up @@ -291,6 +294,48 @@ const SelectionField = styled('div')`
&:focus-within {
z-index: 1;
}

/* react-select defaults to white control and menu backgrounds and dark text
(https://github.com/JedWatson/react-select/blob/4b6948078684bee394e09dd8e7cdc2d7f89e0fad/packages/react-select/src/theme.ts#L12-L21,
https://github.com/JedWatson/react-select/blob/4b6948078684bee394e09dd8e7cdc2d7f89e0fad/packages/react-select/src/components/Control.tsx#L55,
https://github.com/JedWatson/react-select/blob/4b6948078684bee394e09dd8e7cdc2d7f89e0fad/packages/react-select/src/components/Menu.tsx#L297,
https://github.com/JedWatson/react-select/blob/4b6948078684bee394e09dd8e7cdc2d7f89e0fad/packages/react-select/src/components/SingleValue.tsx#L46);
map them to the site's dark theme. */
.dark & {
.layer-select__control {
background-color: var(--gray-a2);
border-color: var(--gray-4);
}
.layer-select__control--is-focused {
border-color: var(--accent-purple);
box-shadow: 0 0 0 0.2rem var(--accent-purple-light);
}
.layer-select__control--is-disabled {
opacity: 0.6;
}
.layer-select__single-value,
.layer-select__input-container {
color: var(--foreground);
}
.layer-select__placeholder {
color: var(--foreground-secondary);
}
.layer-select__menu {
background-color: var(--gray-2);
box-shadow: var(--shadow-6);
}
.layer-select__option {
background-color: transparent;
color: var(--foreground);
}
.layer-select__option--is-focused {
background-color: var(--gray-a4);
}
.layer-select__option--is-selected {
background-color: var(--accent-purple);
color: white;
}
}
`;

const SelectionLabel = styled('label')`
Expand Down
Loading