Skip to content

Commit 3f5f6de

Browse files
test(session): use Truth in the new session serialization tests
Also swaps assertFalse(serialize(...).contains(...)) for Truth's doesNotContain, which reports the offending json on failure instead of just "expected false". The two new PreviousSessionFinalizerTest cases are left on Mockito argThat, which needs a Boolean predicate rather than an assertion. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent da73506 commit 3f5f6de

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎sentry/src/test/java/io/sentry/protocol/SessionSerializationTest.kt‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package io.sentry.protocol
22

3+
import com.google.common.truth.Truth.assertThat
34
import io.sentry.DateUtils
45
import io.sentry.FileFromResources
56
import io.sentry.ILogger
@@ -10,7 +11,6 @@ import io.sentry.Session
1011
import java.io.StringReader
1112
import java.io.StringWriter
1213
import kotlin.test.assertEquals
13-
import kotlin.test.assertFalse
1414
import org.junit.Test
1515
import org.mockito.kotlin.mock
1616

@@ -59,19 +59,19 @@ class SessionSerializationTest {
5959
val session = Session(null, null, "environment", "release")
6060
session.recordNonTerminatingUnhandledError()
6161
session.end()
62-
assertEquals(Session.State.Unhandled, session.status)
62+
assertThat(session.status).isEqualTo(Session.State.Unhandled)
6363

6464
val deserialized = deserialize(serialize(session))
6565

66-
assertEquals(Session.State.Unhandled, deserialized.status)
67-
assertEquals(true, deserialized.hasNonTerminatingUnhandledError())
66+
assertThat(deserialized.status).isEqualTo(Session.State.Unhandled)
67+
assertThat(deserialized.hasNonTerminatingUnhandledError()).isTrue()
6868
}
6969

7070
@Test
7171
fun `non-terminating flag is omitted when unset`() {
7272
val session = Session(null, null, "environment", "release")
7373

74-
assertFalse(serialize(session).contains("non_terminating_unhandled_error"))
74+
assertThat(serialize(session)).doesNotContain("non_terminating_unhandled_error")
7575
}
7676

7777
// Helper

0 commit comments

Comments
 (0)