ref(core): Remove deprecated Hub APIs (#6223)

* ref(core): Remove deprecated Hub APIs

Remove the Hub compatibility layer and migration aliases now that IScopes and Scopes are the supported APIs.

Refs GH-3069

Co-Authored-By: Claude <noreply@anthropic.com>

* changelog

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: adinauer

.cursor/rules/api.mdc

@@ -63,15 +63,13 @@ When adding a new method that users can call (e.g. a new scope operation), these
 7. `NoOpScope` — no-op stub for `IScope`
 8. `NoOpScopes` — no-op stub for `IScopes`
 9. `ScopesAdapter` — delegates to `Sentry` static API
-10. `HubAdapter` — deprecated bridge from old `IHub` API
-11. `HubScopesWrapper` — wraps `IScopes` as `IHub`
 
 ### Serialization (if the data is sent to Sentry)
-12. Add serialization/deserialization in the relevant data class or create a new one implementing `JsonSerializable` and `JsonDeserializer`
+10. Add serialization/deserialization in the relevant data class or create a new one implementing `JsonSerializable` and `JsonDeserializer`
 
 ### Tests
-13. Write tests for all implementations, especially `Scope`, `Scopes`, `SentryTest`, and any new data classes
-14. No-op classes typically don't need separate tests unless they have non-trivial logic
+11. Write tests for all implementations, especially `Scope`, `Scopes`, `SentryTest`, and any new data classes
+12. No-op classes typically don't need separate tests unless they have non-trivial logic
 
 ## Protocol / Data Model Classes
 

.cursor/rules/scopes.mdc

@@ -14,8 +14,8 @@ Data itself is stored on `Scope` instances.
 ## `Hub`
 
 Up until major version 7 of the Java SDK the `IHub` interface was a central part of the SDK.
-In major version 8 we replaced the `IHub` interface with `IScopes`. `IHub` has been deprecated.
-While there is some bridging code in place to allow for easier migration, we are planning to remove it in an upcoming major.
+In major version 8 we replaced the `IHub` interface with `IScopes` and deprecated the Hub compatibility APIs.
+Those compatibility APIs were removed in major version 9.
 
 ## Scope Types
 
@@ -79,7 +79,7 @@ There were several implementations of the `IHub` interface:
 `HubAdapter` has been replaced by `ScopesAdapter`
 `Hub.clone` should be replaced by using `pushScope` or `pushIsolationScope`
 `Sentry.getCurrentHub` has been replaced by `Sentry.getCurrentScopes`
-`Sentry.popScope` has been deprecated. Instead `close` should be called on the `ISentryLifecycleToken` returned e.g. by `pushScope`. This can also be done in a `try-with-resource` block.
+`Sentry.popScope` was deprecated in version 8 and removed in version 9. Instead, `close` should be called on the `ISentryLifecycleToken` returned e.g. by `pushScope`. This can also be done in a `try-with-resources` block.
 
 ## `globalHubMode`
 The SDK has a `globalHubMode` option which affects forking behaviour of the SDK.
@@ -93,8 +93,8 @@ For JVM Backend applications (servers) we discourage enabling `globalHubMode` si
 If `globalHubMode` is enabled, the SDK avoids forking scopes _implicitly_.
 
 This means, retrieving current scopes on a thread where specific scopes do not exist yet for the thread, the root scopes are not forked but returned directly.
-`Sentry.pushScope`, `Sentry.pushIsolationScope` and `Sentry.popScope` are no-ops.
-They are unbalanced API: the caller may never restore the previous scopes, or restore them on a different thread, which would corrupt the globally shared scopes.
+`Sentry.pushScope` and `Sentry.pushIsolationScope` are no-ops and return no-op lifecycle tokens.
+Implicit forking is suppressed because callers could otherwise fail to restore the previous scopes, or restore them on a different thread, which would corrupt the globally shared scopes.
 
 `Sentry.withScope` and `Sentry.withIsolationScope` do fork, also when `globalHubMode` is enabled.
 They are balanced by construction and always restore the previous scopes before returning, so they cannot corrupt the shared scopes.

CHANGELOG.md

@@ -10,6 +10,7 @@
   - `Sentry.showUserFeedbackDialog(...)`: use `Sentry.feedback().show(...)` instead
   - Android: `SentryUserFeedbackDialog`: use `SentryUserFeedbackForm` instead
   - Android: the `SentryUserFeedbackButton` view and composable: call `Sentry.feedback().show()` from your own button instead
+- Remove deprecated Hub compatibility APIs in favor of `IScopes` and `Scopes` ([#6223](https://github.com/getsentry/sentry-java/pull/6223))
 - Remove the aggregate Sentry Logs and Metrics enable options from all configuration surfaces:
   - Java API: `options.getLogs().setEnabled(...)` and `options.getMetrics().setEnabled(...)`
   - Properties files: `logs.enabled` and `metrics.enabled`

sentry-android-core/src/test/java/io/sentry/android/core/SentryAndroidTest.kt

@@ -401,7 +401,7 @@ class SentryAndroidTest {
   fun `init starts session replay if app is in foreground`() {
     initSentryWithForegroundImportance(true) { _ ->
       Shadows.shadowOf(Looper.getMainLooper()).idle()
-      assertTrue(Sentry.getCurrentHub().options.replayController.isRecording())
+      assertTrue(Sentry.getCurrentScopes().options.replayController.isRecording())
     }
   }
 
@@ -410,7 +410,7 @@ class SentryAndroidTest {
   fun `init does not start session replay if the app is in background`() {
     initSentryWithForegroundImportance(false) { _ ->
       Shadows.shadowOf(Looper.getMainLooper()).idle()
-      assertFalse(Sentry.getCurrentHub().options.replayController.isRecording())
+      assertFalse(Sentry.getCurrentScopes().options.replayController.isRecording())
     }
   }
 

sentry-android-integration-tests/sentry-uitest-android-critical/src/main/java/io/sentry/uitest/android/critical/MainActivity.kt

@@ -36,7 +36,8 @@ class MainActivity : ComponentActivity() {
 
     super.onCreate(savedInstanceState)
     val outboxPath =
-      Sentry.getCurrentHub().options.outboxPath ?: throw RuntimeException("Outbox path is not set.")
+      Sentry.getCurrentScopes().options.outboxPath
+        ?: throw RuntimeException("Outbox path is not set.")
 
     requestPermissionLauncher =
       registerForActivityResult(ActivityResultContracts.RequestPermission()) { isGranted: Boolean ->

sentry-graphql-core/api/sentry-graphql-core.api

@@ -11,7 +11,6 @@ public final class io/sentry/graphql/ExceptionReporter {
 public final class io/sentry/graphql/ExceptionReporter$ExceptionDetails {
 	public fun <init> (Lio/sentry/IScopes;Lgraphql/execution/instrumentation/parameters/InstrumentationExecutionParameters;Z)V
 	public fun <init> (Lio/sentry/IScopes;Lgraphql/schema/DataFetchingEnvironment;Z)V
-	public fun getHub ()Lio/sentry/IScopes;
 	public fun getQuery ()Ljava/lang/String;
 	public fun getScopes ()Lio/sentry/IScopes;
 	public fun getVariables ()Ljava/util/Map;

sentry-graphql-core/src/main/java/io/sentry/graphql/ExceptionReporter.java

@@ -163,14 +163,6 @@ public boolean isSubscription() {
       return isSubscription;
     }
 
-    /**
-     * @deprecated please use {@link ExceptionDetails#getScopes()} instead.
-     */
-    @Deprecated
-    public @NotNull IScopes getHub() {
-      return scopes;
-    }
-
     public @NotNull IScopes getScopes() {
       return scopes;
     }

sentry-spring-7/api/sentry-spring-7.api

@@ -381,7 +381,6 @@ public final class io/sentry/spring7/tracing/TransactionNameWithSource {
 }
 
 public abstract class io/sentry/spring7/webflux/AbstractSentryWebFilter : org/springframework/web/server/WebFilter {
-	public static final field SENTRY_HUB_KEY Ljava/lang/String;
 	public static final field SENTRY_SCOPES_KEY Ljava/lang/String;
 	public fun <init> (Lio/sentry/IScopes;)V
 	protected fun doFinally (Lorg/springframework/web/server/ServerWebExchange;Lio/sentry/IScopes;Lio/sentry/ITransaction;)V

sentry-spring-7/src/main/java/io/sentry/spring7/webflux/AbstractSentryWebFilter.java

@@ -37,11 +37,6 @@ public abstract class AbstractSentryWebFilter implements WebFilter {
   private final @NotNull SentryRequestResolver sentryRequestResolver;
   public static final String SENTRY_SCOPES_KEY = "sentry-scopes";
 
-  /**
-   * @deprecated please use {@link AbstractSentryWebFilter#SENTRY_SCOPES_KEY} instead.
-   */
-  @Deprecated public static final String SENTRY_HUB_KEY = SENTRY_SCOPES_KEY;
-
   private static final String TRANSACTION_OP = "http.server";
 
   public AbstractSentryWebFilter(final @NotNull IScopes scopes) {

sentry-spring-jakarta/api/sentry-spring-jakarta.api

@@ -381,7 +381,6 @@ public final class io/sentry/spring/jakarta/tracing/TransactionNameWithSource {
 }
 
 public abstract class io/sentry/spring/jakarta/webflux/AbstractSentryWebFilter : org/springframework/web/server/WebFilter {
-	public static final field SENTRY_HUB_KEY Ljava/lang/String;
 	public static final field SENTRY_SCOPES_KEY Ljava/lang/String;
 	public fun <init> (Lio/sentry/IScopes;)V
 	protected fun doFinally (Lorg/springframework/web/server/ServerWebExchange;Lio/sentry/IScopes;Lio/sentry/ITransaction;)V