ref(android): Fix Error Prone warnings in sentry-android-core (#6499)

* ref(android): Fix Error Prone warnings in sentry-android-core

Error Prone never ran on sentry-android-core. Enabling it reports 59 warnings outside Javadoc,
which fail the build under -Werror.

- Suppress FutureReturnValueIgnored, JavaUtilDate, and ReferenceEquality where identity is
  intended, as the sentry module does.
- Keep the AnrProfilingIntegration updater a field, since removeCallbacks needs the instance that
  was posted, and suppress UnnecessaryLambda there.
- Read the ANR thread dump and the app start profiling config as UTF-8, Android's default charset.
- Remove unused fields and parameters, add missing @OverRide, make long-to-double conversions
  explicit, and narrow members that are effectively private or protected in a final class.
- Explain the two catch blocks that ignore their exception.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ref(android): Fix the Error Prone warnings only main has

- ANRWatchDog.monotonicTicker is never read (#6041), since the ticker lambda captures the
  constructor parameter. Remove the field and keep the parameter.
- ActivityFramesTracker.lock is protected in a final class; make it package-private.
- LifecycleWatcher reads the session start Date to seed the session window; suppress JavaUtilDate
  there, as the other Date uses are.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ref(android): Keep the default charset reads as they were

Android's default charset is always UTF-8, so DefaultCharset is
disabled for the Android modules in #6493 instead of being fixed here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ref(android): Drop the UnnecessaryLambda suppressions

#6493 disables UnnecessaryLambda for the Android modules, so the
suppressions on the ANRWatchDog and AnrProfilingIntegration fields
are redundant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ref(android): Drop the updater field comment

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(android): Make the local-class method comment a plain comment

Error Prone's NotJavadoc flags Javadoc on methods of local classes, which
#6537 added in AndroidConnectionStatusProvider.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Author: runningcode

sentry-android-core/src/main/java/io/sentry/android/core/ANRWatchDog.java

@@ -49,7 +49,6 @@ final class ANRWatchDog extends Thread {
   private final boolean reportInDebug;
   private final ANRListener anrListener;
   private final MainLooperHandler uiHandler;
-  private final MonotonicTicker monotonicTicker;
 
   /** the interval in which we check if there's an ANR, in ms */
   private long pollingIntervalMs;
@@ -65,7 +64,6 @@ final class ANRWatchDog extends Thread {
   private final @NotNull Context context;
   private final @Nullable IDebugManager debugManager;
 
-  @SuppressWarnings("UnnecessaryLambda")
   private final Runnable ticker;
 
   static @NotNull ANRWatchDog create(
@@ -97,7 +95,6 @@ final class ANRWatchDog extends Thread {
 
     super("|ANR-WatchDog|");
 
-    this.monotonicTicker = monotonicTicker;
     this.timeoutIntervalMillis = timeoutIntervalMillis;
     this.pollingIntervalMs = pollingIntervalMillis;
     this.reportInDebug = reportInDebug;

sentry-android-core/src/main/java/io/sentry/android/core/ActivityFramesTracker.java

@@ -40,7 +40,7 @@ public final class ActivityFramesTracker {
       new WeakHashMap<>();
 
   private final @NotNull MainLooperHandler handler;
-  protected @NotNull AutoClosableReentrantLock lock = new AutoClosableReentrantLock();
+  @NotNull AutoClosableReentrantLock lock = new AutoClosableReentrantLock();
 
   private final @NotNull LazyEvaluator<Boolean> androidXAvailable;
 

sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java

@@ -496,6 +496,7 @@ void applyScope(final @NotNull IScope scope, final @NotNull ITransaction transac
   }
 
   @VisibleForTesting
+  @SuppressWarnings("ReferenceEquality")
   void clearScope(final @NotNull IScope scope, final @NotNull ITransaction transaction) {
     scope.withTransaction(
         scopeTransaction -> {

sentry-android-core/src/main/java/io/sentry/android/core/AndroidContinuousProfiler.java

@@ -335,6 +335,7 @@ private void stop(final boolean restartProfiler) {
     }
   }
 
+  @Override
   public void reevaluateSampling() {
     shouldSample = true;
   }
@@ -373,6 +374,7 @@ public void close(final boolean isTerminating) {
     return ProfileRecordingState.UNKNOWN;
   }
 
+  @SuppressWarnings("FutureReturnValueIgnored")
   private void sendChunks(final @NotNull IScopes scopes, final @NotNull SentryOptions options) {
     try {
       options

sentry-android-core/src/main/java/io/sentry/android/core/AndroidFatalLogger.java

@@ -27,9 +27,9 @@ public void log(
       final @NotNull String message,
       final @Nullable Object... args) {
     if (args == null || args.length == 0) {
-      Log.println(toLogcatLevel(level), tag, message);
+      Log.println(Log.ASSERT, tag, message);
     } else {
-      Log.println(toLogcatLevel(level), tag, String.format(message, args));
+      Log.println(Log.ASSERT, tag, String.format(message, args));
     }
   }
 
@@ -59,8 +59,4 @@ public void log(
   public boolean isEnabled(@Nullable SentryLevel level) {
     return true;
   }
-
-  private int toLogcatLevel(final @NotNull SentryLevel sentryLevel) {
-    return Log.ASSERT;
-  }
 }

sentry-android-core/src/main/java/io/sentry/android/core/AndroidLoggerBatchProcessor.java

@@ -23,6 +23,7 @@ public void onForeground() {
   }
 
   @Override
+  @SuppressWarnings("FutureReturnValueIgnored")
   public void onBackground() {
     if (!hasAcceptedItem) {
       return;

sentry-android-core/src/main/java/io/sentry/android/core/AndroidMetricsBatchProcessor.java

@@ -23,6 +23,7 @@ public void onForeground() {
   }
 
   @Override
+  @SuppressWarnings("FutureReturnValueIgnored")
   public void onBackground() {
     if (!hasAcceptedItem) {
       return;

sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java

@@ -502,7 +502,7 @@ static void installDefaultIntegrations(
       options.setReplayController(replay);
     }
     if (isDistributionAvailable) {
-      final DistributionIntegration distribution = new DistributionIntegration((context));
+      final DistributionIntegration distribution = new DistributionIntegration(context);
       options.setDistributionController(distribution);
       options.addIntegration(distribution);
     }

sentry-android-core/src/main/java/io/sentry/android/core/AnrIntegration.java

@@ -47,15 +47,15 @@ public AnrIntegration(final @NotNull Context context) {
 
   private @Nullable SentryOptions options;
 
-  protected static final @NotNull AutoClosableReentrantLock watchDogLock =
-      new AutoClosableReentrantLock();
+  static final @NotNull AutoClosableReentrantLock watchDogLock = new AutoClosableReentrantLock();
 
   @Override
   public final void register(final @NotNull IScopes scopes, final @NotNull SentryOptions options) {
     this.options = Objects.requireNonNull(options, "SentryOptions is required");
     register(scopes, (SentryAndroidOptions) options);
   }
 
+  @SuppressWarnings("FutureReturnValueIgnored")
   private void register(
       final @NotNull IScopes scopes, final @NotNull SentryAndroidOptions options) {
     options

sentry-android-core/src/main/java/io/sentry/android/core/AnrV2Integration.java

@@ -64,6 +64,7 @@ public AnrV2Integration(final @NotNull Context context) {
 
   @SuppressLint("NewApi") // we do the check in the AnrIntegrationFactory
   @Override
+  @SuppressWarnings("FutureReturnValueIgnored")
   public void register(@NotNull IScopes scopes, @NotNull SentryOptions options) {
     this.options =
         Objects.requireNonNull(