Skip to content

Commit 4a2c19f

Browse files
runningcodeclaude
andauthored
build: Move aspectjweaver and kotlin-reflect to the version catalog (#6514)
Replace the string coordinates and the Config.Libs constants with catalog entries. Both stay versionless: Spring BOMs manage aspectjweaver and the Kotlin plugin manages kotlin-reflect. sentry-apollo-4 pinned kotlin-reflect to 2.0.0 in tests, but mockito-kotlin already pulled in 2.1.20, so the pin had no effect. It now resolves to 2.3.21, the same version as stdlib. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 2efb348 commit 4a2c19f

26 files changed

Lines changed: 41 additions & 41 deletions

File tree

‎buildSrc/src/main/java/Config.kt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ object Config {
2020
val springSecurityWeb = "org.springframework.security:spring-security-web"
2121
val springSecurityConfig = "org.springframework.security:spring-security-config"
2222
val springAop = "org.springframework:spring-aop"
23-
val aspectj = "org.aspectj:aspectjweaver"
2423

25-
val kotlinReflect = "org.jetbrains.kotlin:kotlin-reflect"
2624
val kotlinStdLib = "org.jetbrains.kotlin:kotlin-stdlib"
2725
}
2826

‎gradle/libs.versions.toml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ androidx-sqlite-bundled = { module = "androidx.sqlite:sqlite-bundled", version.r
131131
androidx-sqlite-framework = { module = "androidx.sqlite:sqlite-framework", version.ref = "sqliteRc" }
132132
androidx-recyclerview = { module = "androidx.recyclerview:recyclerview", version = "1.4.0" }
133133
androidx-browser = { module = "androidx.browser:browser", version = "1.10.0" }
134+
aspectjweaver = { module = "org.aspectj:aspectjweaver" }
134135
async-profiler = { module = "tools.profiler:async-profiler", version.ref = "asyncProfiler" }
135136
async-profiler-jfr-converter = { module = "tools.profiler:jfr-converter", version.ref = "asyncProfiler" }
136137
caffeine = { module = "com.github.ben-manes.caffeine:caffeine" }
@@ -148,6 +149,7 @@ jackson-bom = { module = "com.fasterxml.jackson:jackson-bom", version.ref = "jac
148149
jackson-databind = { module = "com.fasterxml.jackson.core:jackson-databind", version.ref = "jackson" }
149150
jetbrains-annotations = { module = "org.jetbrains:annotations", version = "23.0.0" }
150151
kotlin-bom = { module = "org.jetbrains.kotlin:kotlin-bom", version.ref = "kotlin" }
152+
kotlin-reflect = { module = "org.jetbrains.kotlin:kotlin-reflect" }
151153
kotlin-test-junit = { module = "org.jetbrains.kotlin:kotlin-test-junit", version.ref = "kotlin" }
152154
kotlinx-coroutines = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-core", version.ref = "coroutines" }
153155
kotlinx-coroutines-android = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-android", version.ref = "coroutines" }

‎sentry-apollo-4/build.gradle.kts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ dependencies {
4444
testImplementation(libs.mockito.kotlin)
4545
testImplementation(libs.mockito.core)
4646
testImplementation(libs.okhttp.mockwebserver)
47-
testImplementation("org.jetbrains.kotlin:kotlin-reflect:2.0.0")
47+
testImplementation(libs.kotlin.reflect)
4848
}
4949

5050
tasks.withType<JavaCompile>().configureEach {

‎sentry-samples/sentry-samples-netflix-dgs/build.gradle.kts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ java.targetCompatibility = JavaVersion.VERSION_1_8
2727
dependencies {
2828
implementation(platform(libs.springboot2.bom))
2929
implementation(libs.springboot.starter.web)
30-
implementation("org.jetbrains.kotlin:kotlin-reflect")
30+
implementation(libs.kotlin.reflect)
3131
implementation(kotlin("stdlib-jdk8", getKotlinPluginVersion()))
3232
implementation("io.sentry:sentry-spring-boot-starter:$sentryVersion")
3333
implementation("io.sentry:sentry-graphql:$sentryVersion")

‎sentry-samples/sentry-samples-spring-7/build.gradle.kts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ dependencyManagement {
3535
dependencies {
3636
implementation("org.springframework:spring-webmvc")
3737
implementation("org.springframework:spring-aop")
38-
implementation("org.aspectj:aspectjweaver")
38+
implementation(libs.aspectjweaver)
3939
implementation("org.springframework.security:spring-security-web")
4040
implementation("org.springframework.security:spring-security-config")
41-
implementation("org.jetbrains.kotlin:kotlin-reflect")
41+
implementation(libs.kotlin.reflect)
4242
implementation(kotlin("stdlib-jdk8", getKotlinPluginVersion()))
4343
implementation("io.sentry:sentry-spring-7:$sentryVersion")
4444
implementation("io.sentry:sentry-logback:$sentryVersion")

‎sentry-samples/sentry-samples-spring-boot-4-log4j2/build.gradle.kts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ dependencies {
4040
implementation(libs.springboot4.starter.websocket)
4141
implementation(libs.springboot4.starter.restclient)
4242
implementation(libs.springboot4.starter.webclient)
43-
implementation("org.aspectj:aspectjweaver")
44-
implementation("org.jetbrains.kotlin:kotlin-reflect")
43+
implementation(libs.aspectjweaver)
44+
implementation(libs.kotlin.reflect)
4545
implementation(kotlin("stdlib-jdk8", getKotlinPluginVersion()))
4646
implementation("io.sentry:sentry-spring-boot-4-starter:$sentryVersion")
4747
implementation("io.sentry:sentry-graphql-22:$sentryVersion")

‎sentry-samples/sentry-samples-spring-boot-4-opentelemetry-noagent/build.gradle.kts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ dependencies {
4040
implementation(libs.springboot4.starter.websocket)
4141
implementation(libs.springboot4.starter.webclient)
4242
implementation(libs.springboot4.starter.restclient)
43-
implementation("org.aspectj:aspectjweaver")
44-
implementation("org.jetbrains.kotlin:kotlin-reflect")
43+
implementation(libs.aspectjweaver)
44+
implementation(libs.kotlin.reflect)
4545
implementation(kotlin("stdlib-jdk8", getKotlinPluginVersion()))
4646
implementation("io.sentry:sentry-spring-boot-4-starter:$sentryVersion")
4747
implementation("io.sentry:sentry-logback:$sentryVersion")

‎sentry-samples/sentry-samples-spring-boot-4-opentelemetry/build.gradle.kts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ dependencies {
4141
implementation(libs.springboot4.starter.websocket)
4242
implementation(libs.springboot4.starter.webclient)
4343
implementation(libs.springboot4.starter.restclient)
44-
implementation("org.aspectj:aspectjweaver")
45-
implementation("org.jetbrains.kotlin:kotlin-reflect")
44+
implementation(libs.aspectjweaver)
45+
implementation(libs.kotlin.reflect)
4646
implementation(kotlin("stdlib-jdk8", getKotlinPluginVersion()))
4747
implementation("io.sentry:sentry-spring-boot-4-starter:$sentryVersion")
4848
implementation("io.sentry:sentry-logback:$sentryVersion")

‎sentry-samples/sentry-samples-spring-boot-4-otlp/build.gradle.kts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ dependencies {
4040
implementation(libs.springboot4.starter.websocket)
4141
implementation(libs.springboot4.starter.restclient)
4242
implementation(libs.springboot4.starter.webclient)
43-
implementation("org.aspectj:aspectjweaver")
44-
implementation("org.jetbrains.kotlin:kotlin-reflect")
43+
implementation(libs.aspectjweaver)
44+
implementation(libs.kotlin.reflect)
4545
implementation(kotlin("stdlib-jdk8", getKotlinPluginVersion()))
4646
implementation("io.sentry:sentry-spring-boot-4-starter:$sentryVersion")
4747
implementation("io.sentry:sentry-logback:$sentryVersion")

‎sentry-samples/sentry-samples-spring-boot-4-webflux/build.gradle.kts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ group = "io.sentry.sample.spring-boot-4-webflux"
1717
version = "0.0.1-SNAPSHOT"
1818

1919
dependencies {
20-
implementation("org.jetbrains.kotlin:kotlin-reflect")
20+
implementation(libs.kotlin.reflect)
2121
implementation(kotlin("stdlib-jdk8", getKotlinPluginVersion()))
2222
implementation("io.sentry:sentry-spring-boot-4-starter:$sentryVersion")
2323
implementation("io.sentry:sentry-logback:$sentryVersion")

0 commit comments

Comments
 (0)