build: Drop the Error Prone and NullAway code fixes, they move to their own PR

Author: markushi

sentry-android-core/src/main/java/io/sentry/android/core/ApplicationNotResponding.java

@@ -17,8 +17,6 @@
 final class ApplicationNotResponding extends RuntimeException {
   private static final long serialVersionUID = 252541144579117016L;
 
-  // Never serialized.
-  @SuppressWarnings("serial")
   private final @Nullable Thread thread;
 
   ApplicationNotResponding(final @Nullable String message) {

sentry-android-core/src/main/java/io/sentry/android/core/SentryUserFeedbackButton.java

@@ -13,8 +13,6 @@
 /**
  * @deprecated `SentryUserFeedbackButton` will be removed in the next major version
  */
-// Constructors call overridable methods; making them final would break the public API.
-@SuppressWarnings("this-escape")
 @Deprecated
 public class SentryUserFeedbackButton extends Button {
 

sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java

@@ -50,8 +50,6 @@
  * <p>This class is also responsible for - determining the app start type (cold, warm) - determining
  * if the app was launched in foreground
  */
-// Constructors call overridable methods; making them final would break the public API.
-@SuppressWarnings("this-escape")
 @ApiStatus.Internal
 public class AppStartMetrics extends ActivityLifecycleCallbacksAdapter {
   public interface HeadlessAppStartListener {

sentry-async-profiler/src/main/java/io/sentry/asyncprofiler/convert/JfrAsyncProfilerToSentryProfileConverter.java

@@ -83,7 +83,7 @@ private class ProfileEventVisitor implements EventCollector.Visitor {
     private final @NotNull JfrReader jfr;
     private final @NotNull Arguments args;
 
-    ProfileEventVisitor(
+    public ProfileEventVisitor(
         @NotNull SentryProfile sentryProfile,
         @NotNull SentryStackTraceFactory stackTraceFactory,
         @NotNull JfrReader jfr,

sentry-jul/src/main/java/io/sentry/jul/SentryHandler.java

@@ -40,8 +40,6 @@
 import org.slf4j.MDC;
 
 /** Logging handler in charge of sending the java.util.logging records to a Sentry server. */
-// Constructors call overridable methods; making them final would break the public API.
-@SuppressWarnings("this-escape")
 @Open
 public class SentryHandler extends Handler {
   public static final String MECHANISM_TYPE = "JulSentryHandler";

sentry-kafka/src/main/java/io/sentry/kafka/SentryKafkaConsumerTracing.java

@@ -247,7 +247,7 @@ private void finishTransaction(
 
     try {
       final double enqueuedTimeSeconds = Double.parseDouble(enqueuedTimeStr);
-      final double nowSeconds = DateUtils.millisToSeconds((double) System.currentTimeMillis());
+      final double nowSeconds = DateUtils.millisToSeconds(System.currentTimeMillis());
       final long latencyMs = (long) ((nowSeconds - enqueuedTimeSeconds) * 1000);
       return latencyMs >= 0 ? latencyMs : null;
     } catch (NumberFormatException ignored) {

sentry-kafka/src/main/java/io/sentry/kafka/SentryKafkaProducer.java

@@ -114,8 +114,7 @@ static final class SentryProducerHandler<K, V> implements InvocationHandler {
     }
 
     @Override
-    // Proxy equals() is identity-based.
-    @SuppressWarnings({"unchecked", "ReferenceEquality"})
+    @SuppressWarnings("unchecked")
     public @Nullable Object invoke(
         final @NotNull Object proxy, final @NotNull Method method, final @Nullable Object[] args)
         throws Throwable {
@@ -237,8 +236,7 @@ private void maybeInjectHeaders(final @NotNull Headers headers, final @Nullable
         headers.remove(SENTRY_ENQUEUED_TIME_HEADER);
         headers.add(
             SENTRY_ENQUEUED_TIME_HEADER,
-            DateUtils.doubleToBigDecimal(
-                    DateUtils.millisToSeconds((double) System.currentTimeMillis()))
+            DateUtils.doubleToBigDecimal(DateUtils.millisToSeconds(System.currentTimeMillis()))
                 .toString()
                 .getBytes(StandardCharsets.UTF_8));
       } catch (Throwable t) {

sentry-logback/src/main/java/io/sentry/logback/SentryAppender.java

@@ -197,8 +197,7 @@ protected void captureLog(@NotNull ILoggingEvent loggingEvent) {
     final @NotNull SentryLogParameters params = SentryLogParameters.create(attributes);
     params.setOrigin("auto.log.logback");
 
-    Sentry.logger()
-        .log(sentryLevel, params, formattedMessage, arguments != null ? arguments : new Object[0]);
+    Sentry.logger().log(sentryLevel, params, formattedMessage, arguments);
   }
 
   @SuppressWarnings("deprecation")

sentry-opentelemetry/sentry-opentelemetry-bootstrap/src/main/java/io/sentry/opentelemetry/OtelContextScopesStorage.java

@@ -17,7 +17,7 @@ public final class OtelContextScopesStorage implements IScopesStorage {
 
   @Override
   public void init() {
-    /*
+    /**
      * We're currently overriding the storage mechanism to allow for cleanup of non closed OTel
      * scopes. These happen when using e.g. Sentry static API due to getCurrentScopes() invoking
      * Context.makeCurrent and then ignoring the returned lifecycle token (OTel Scope). After fixing

sentry-opentelemetry/sentry-opentelemetry-bootstrap/src/main/java/io/sentry/opentelemetry/SentryOtelThreadLocalStorage.java

@@ -29,8 +29,6 @@ public final class SentryOtelThreadLocalStorage implements ContextStorage {
 
   private static final ThreadLocal<Context> THREAD_LOCAL_STORAGE = new ThreadLocal<>();
 
-  // Same identity check as OpenTelemetry's ThreadLocalContextStorage.
-  @SuppressWarnings("ReferenceEquality")
   @Override
   public Scope attach(Context toAttach) {
     if (toAttach == null) {