Skip to content

Commit 6375c65

Browse files
adinauerclaude
andcommitted
fix(core): Expose mutable Kotlin Data Collection options
Align nullable Boolean getters and setters so Kotlin exposes mutable synthetic properties. Allow callers to clear an explicit override by assigning null. Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 85b919f commit 6375c65

3 files changed

Lines changed: 41 additions & 10 deletions

File tree

‎sentry/api/sentry.api‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -398,19 +398,19 @@ public final class io/sentry/DataCollection {
398398
public fun getUserInfo ()Ljava/lang/Boolean;
399399
public fun isExplicitlyConfigured ()Z
400400
public fun setCookies (Lio/sentry/KeyValueCollectionBehavior;)V
401-
public fun setDatabaseQueryData (Z)V
402-
public fun setFilePaths (Z)V
401+
public fun setDatabaseQueryData (Ljava/lang/Boolean;)V
402+
public fun setFilePaths (Ljava/lang/Boolean;)V
403403
public fun setHttpBodies (Ljava/util/Set;)V
404404
public fun setUrlQueryParams (Lio/sentry/KeyValueCollectionBehavior;)V
405-
public fun setUserInfo (Z)V
405+
public fun setUserInfo (Ljava/lang/Boolean;)V
406406
}
407407

408408
public final class io/sentry/DataCollection$Graphql {
409409
public fun <init> ()V
410410
public fun getDocument ()Ljava/lang/Boolean;
411411
public fun getVariables ()Ljava/lang/Boolean;
412-
public fun setDocument (Z)V
413-
public fun setVariables (Z)V
412+
public fun setDocument (Ljava/lang/Boolean;)V
413+
public fun setVariables (Ljava/lang/Boolean;)V
414414
}
415415

416416
public final class io/sentry/DataCollection$HttpHeaders {

‎sentry/src/main/java/io/sentry/DataCollection.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public DataCollection(final boolean forceDataCollection) {
3434
return userInfo;
3535
}
3636

37-
public void setUserInfo(final boolean userInfo) {
37+
public void setUserInfo(final @Nullable Boolean userInfo) {
3838
this.userInfo = userInfo;
3939
}
4040

@@ -71,15 +71,15 @@ public void setHttpBodies(final @Nullable Set<HttpBodyType> httpBodies) {
7171
return databaseQueryData;
7272
}
7373

74-
public void setDatabaseQueryData(final boolean databaseQueryData) {
74+
public void setDatabaseQueryData(final @Nullable Boolean databaseQueryData) {
7575
this.databaseQueryData = databaseQueryData;
7676
}
7777

7878
public @Nullable Boolean getFilePaths() {
7979
return filePaths;
8080
}
8181

82-
public void setFilePaths(final boolean filePaths) {
82+
public void setFilePaths(final @Nullable Boolean filePaths) {
8383
this.filePaths = filePaths;
8484
}
8585

@@ -139,15 +139,15 @@ public static final class Graphql {
139139
return document;
140140
}
141141

142-
public void setDocument(final boolean document) {
142+
public void setDocument(final @Nullable Boolean document) {
143143
this.document = document;
144144
}
145145

146146
public @Nullable Boolean getVariables() {
147147
return variables;
148148
}
149149

150-
public void setVariables(final boolean variables) {
150+
public void setVariables(final @Nullable Boolean variables) {
151151
this.variables = variables;
152152
}
153153

‎sentry/src/test/java/io/sentry/DataCollectionTest.kt‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,37 @@ class DataCollectionTest {
4848
assertThat(dataCollection.isExplicitlyConfigured()).isTrue()
4949
}
5050

51+
@Test
52+
fun `nullable Boolean options are mutable Kotlin properties`() {
53+
val dataCollection = DataCollection(false)
54+
55+
dataCollection.userInfo = false
56+
dataCollection.databaseQueryData = false
57+
dataCollection.filePaths = false
58+
dataCollection.graphql.document = false
59+
dataCollection.graphql.variables = false
60+
61+
assertThat(dataCollection.userInfo).isFalse()
62+
assertThat(dataCollection.databaseQueryData).isFalse()
63+
assertThat(dataCollection.filePaths).isFalse()
64+
assertThat(dataCollection.graphql.document).isFalse()
65+
assertThat(dataCollection.graphql.variables).isFalse()
66+
assertThat(dataCollection.isExplicitlyConfigured()).isTrue()
67+
68+
dataCollection.userInfo = null
69+
dataCollection.databaseQueryData = null
70+
dataCollection.filePaths = null
71+
dataCollection.graphql.document = null
72+
dataCollection.graphql.variables = null
73+
74+
assertThat(dataCollection.userInfo).isNull()
75+
assertThat(dataCollection.databaseQueryData).isNull()
76+
assertThat(dataCollection.filePaths).isNull()
77+
assertThat(dataCollection.graphql.document).isNull()
78+
assertThat(dataCollection.graphql.variables).isNull()
79+
assertThat(dataCollection.isExplicitlyConfigured()).isFalse()
80+
}
81+
5182
@Test
5283
fun `empty HTTP body set is distinct from unset`() {
5384
val dataCollection = DataCollection(false)

0 commit comments

Comments
 (0)