Skip to content

Commit 67c065c

Browse files
authored
ci: Remove benchmark workflow that comments on PRs (#5972)
* ci: Remove benchmark workflow that comments on PRs The `app-metrics` job in integration-tests-benchmarks.yml ran the plain and Sentry test apps through SauceLabs on every PR and posted a "Performance metrics" comment with startup-time and size diffs. The numbers were not actionable: recent runs reported 0 B for both app sizes, and the startup diff swung between 22 ms and 143 ms across unrelated changes. Removing the whole workflow also drops its SauceLabs `test` job, which leaves several things with no remaining caller. Removed here as well: - `test-app-plain` and `test-app-sentry`, built only by `app-metrics` - `metrics-test.yml`, the app-metrics test specification - `.sauce/sentry-uitest-android-benchmark.yml` and its `-lite` variant, passed to saucectl only by the `test` job - the `make assembleBenchmarks` alias, called only by the `test` job The `sentry-uitest-android-benchmark` module itself is kept. It no longer runs in CI, but it still builds and can be run locally. * ci: Remove the now-unused sentry-uitest-android-benchmark module The Espresso benchmark module was only exercised by the SauceLabs `test` job in the workflow removed in the previous commit. Nothing runs it any more, and the numbers it produced were the same noisy startup-time and app-size measurements that made the PR comment unactionable, so keeping it around only costs maintenance. Also drops its `settings.gradle.kts` / `build.gradle.kts` entries, the `make assembleBenchmarkTestRelease` target, and the README references.
1 parent 6a1c02c commit 67c065c

96 files changed

Lines changed: 1 addition & 2649 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/workflows/integration-tests-benchmarks.yml‎

Lines changed: 0 additions & 114 deletions
This file was deleted.

‎.sauce/sentry-uitest-android-benchmark-lite.yml‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎.sauce/sentry-uitest-android-benchmark.yml‎

Lines changed: 0 additions & 56 deletions
This file was deleted.

‎Makefile‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
.PHONY: all clean compile javadocs dryRelease update checkFormat api assembleBenchmarkTestRelease assembleUiTestRelease assembleUiTestCriticalRelease runUiTestCritical setupPython systemTest systemTestInteractive check preMerge publish
1+
.PHONY: all clean compile javadocs dryRelease update checkFormat api assembleUiTestRelease assembleUiTestCriticalRelease runUiTestCritical setupPython systemTest systemTestInteractive check preMerge publish
22

33
all: stop clean javadocs compile
4-
assembleBenchmarks: assembleBenchmarkTestRelease
54
assembleUiTests: assembleUiTestRelease
65
preMerge: check
76
publish: clean dryRelease
@@ -35,10 +34,6 @@ checkFormat:
3534
api:
3635
./gradlew apiDump
3736

38-
# Assemble release and Android test apk of the uitest-android-benchmark module
39-
assembleBenchmarkTestRelease:
40-
./gradlew :sentry-android-integration-tests:sentry-uitest-android-benchmark:assembleRelease :sentry-android-integration-tests:sentry-uitest-android-benchmark:assembleAndroidTest
41-
4237
# Assemble release and Android test apk of the uitest-android module
4338
assembleUiTestRelease:
4439
./gradlew :sentry-android-integration-tests:sentry-uitest-android:assembleRelease :sentry-android-integration-tests:sentry-uitest-android:assembleAndroidTest

‎build.gradle.kts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,7 @@ apiValidation {
7777
"sentry-samples-spring-boot-4-webflux",
7878
"sentry-samples-ktor-client",
7979
"sentry-uitest-android",
80-
"sentry-uitest-android-benchmark",
8180
"sentry-uitest-android-critical",
82-
"test-app-plain",
83-
"test-app-sentry",
8481
"test-app-size",
8582
"sentry-samples-netflix-dgs",
8683
"sentry-samples-console-otlp",
Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
11
# Android performance-impact and integration tests
22

3-
* [Sample app without sentry](./test-app-plain) created with Android Studio -> New Project -> Basic Activity
4-
* [Same app, but with Sentry included](./test-app-sentry) - made part of the root project
5-
* [App metrics test specification (yaml)](./metrics-test.yml)
6-
* [Espresso-based benchmarks](./sentry-uitest-android-benchmark) - run within SauceLabs (see /.sauce/*.yml)
73
* [Espresso-based UI tests](./sentry-uitest-android) - run within SauceLabs (see /.sauce/*.yml)
84
* Also used for compatibility test matrix against new AGP versions

‎sentry-android-integration-tests/metrics-test.yml‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎sentry-android-integration-tests/sentry-uitest-android-benchmark/.gitignore‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎sentry-android-integration-tests/sentry-uitest-android-benchmark/benchmark-proguard-rules.pro‎

Lines changed: 0 additions & 38 deletions
This file was deleted.

0 commit comments

Comments
 (0)