Skip to content

Commit 6a66949

Browse files
adinauerclaude
andcommitted
ref(core): Rename URL query parameter resolver
Keep the internal resolver and its tests aligned with the canonical public Data Collection option name. Refs #5666 Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 9b6ddb7 commit 6a66949

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎sentry/api/sentry.api‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,7 @@ public final class io/sentry/DataCollectionResolver {
419419
public fun getCookies ()Lio/sentry/KeyValueCollectionBehavior;
420420
public fun getHttpRequestHeaders ()Lio/sentry/KeyValueCollectionBehavior;
421421
public fun getHttpResponseHeaders ()Lio/sentry/KeyValueCollectionBehavior;
422-
public fun getQueryParams ()Lio/sentry/KeyValueCollectionBehavior;
422+
public fun getUrlQueryParams ()Lio/sentry/KeyValueCollectionBehavior;
423423
public fun isDataCollectionConfigured ()Z
424424
public fun isDatabaseQueryData ()Z
425425
public fun isGraphqlDocument ()Z

‎sentry/src/main/java/io/sentry/DataCollectionResolver.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ public boolean isGraphqlVariables() {
5252
return options.isSendDefaultPii() ? EMPTY_DENY_LIST : OFF;
5353
}
5454

55-
public @NotNull KeyValueCollectionBehavior getQueryParams() {
56-
return explicitOrEmptyDenyList(options.getDataCollection().getQueryParams());
55+
public @NotNull KeyValueCollectionBehavior getUrlQueryParams() {
56+
return explicitOrEmptyDenyList(options.getDataCollection().getUrlQueryParams());
5757
}
5858

5959
public @NotNull KeyValueCollectionBehavior getHttpRequestHeaders() {

‎sentry/src/test/java/io/sentry/DataCollectionResolverTest.kt‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class DataCollectionResolverTest {
2525

2626
assertThat(options.dataCollectionResolver.isDataCollectionConfigured).isFalse()
2727

28-
options.dataCollection.queryParams = KeyValueCollectionBehavior.denyList()
28+
options.dataCollection.urlQueryParams = KeyValueCollectionBehavior.denyList()
2929

3030
assertThat(options.dataCollectionResolver.isDataCollectionConfigured).isTrue()
3131
}
@@ -125,21 +125,21 @@ class DataCollectionResolverTest {
125125
}
126126

127127
@Test
128-
fun `query params use default deny list when unset`() {
128+
fun `URL query params use default deny list when unset`() {
129129
val options = SentryOptions()
130130

131-
assertThat(options.dataCollectionResolver.queryParams)
131+
assertThat(options.dataCollectionResolver.urlQueryParams)
132132
.isEqualTo(KeyValueCollectionBehavior.denyList())
133133
}
134134

135135
@Test
136-
fun `query params override takes precedence`() {
136+
fun `URL query params override takes precedence`() {
137137
val options = SentryOptions()
138138
val behavior = KeyValueCollectionBehavior.allowList("language", "theme")
139139

140-
options.dataCollection.queryParams = behavior
140+
options.dataCollection.urlQueryParams = behavior
141141

142-
assertThat(options.dataCollectionResolver.queryParams).isEqualTo(behavior)
142+
assertThat(options.dataCollectionResolver.urlQueryParams).isEqualTo(behavior)
143143
}
144144

145145
@Test

0 commit comments

Comments
 (0)