Repository navigation
Commit 6d8b5ae
fix(android): Release the nav transaction when unbinding throws
unbindTransaction cleared the scope before telling the coordinator to stop
retaining the transaction. Scope.clearTransaction notifies the host app's scope
observers in an unguarded loop, so one of them can throw and skip the
coordinator call, leaving a retired transaction retained. Regaining the lease
would then rebind it, attaching the new destination's spans to a transaction
for a destination the user had already left.
Tell the coordinator first. releaseTransaction runs no host app code and cannot
throw, and nothing in the unbind depends on it having run.
Add regression coverage for a scope observer throwing during the unbind.
Refs JAVA-274
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent f673e42 commit 6d8b5ae
2 files changed
Lines changed: 31 additions & 5 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
83 | 82 | | |
84 | 83 | | |
85 | 84 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
| |||
175 | 177 | | |
176 | 178 | | |
177 | 179 | | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
178 | 202 | | |
179 | 203 | | |
180 | 204 | | |
| |||
332 | 356 | | |
333 | 357 | | |
334 | 358 | | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
335 | 362 | | |
336 | 363 | | |
337 | 364 | | |
| |||
0 commit comments