Skip to content

Commit 6ed91a1

Browse files
runningcodeclaude
andcommitted
fix(replay): Avoid Kotlin stdlib classes replay didn't use before
The function references and generateSequence pulled in kotlin.jvm.internal.FunctionReferenceImpl and kotlin.sequences.SequencesKt, which R8 reports as missing in the SDK size app. A lambda and a plain loop keep replay's Kotlin stdlib footprint as it was. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 2d151a4 commit 6ed91a1

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

‎sentry-android-replay/src/main/java/io/sentry/android/replay/capture/BaseCaptureStrategy.kt‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,12 @@ constructor(
261261
val oldTimeline = clock.timeline
262262
val oldTimelineEnd = oldTimeline.nowMillis()
263263
val newTimeline = clock.restart()
264-
val oldEvents = generateSequence { currentEvents.pollFirst() }.toCollection(ArrayDeque())
264+
val oldEvents = ArrayDeque<RRWebEvent>()
265+
var event = currentEvents.pollFirst()
266+
while (event != null) {
267+
oldEvents.add(event)
268+
event = currentEvents.pollFirst()
269+
}
265270
val jump = TimelineJump(oldTimeline, oldTimelineEnd, newTimeline, oldEvents)
266271
StampedFrame(jump.newTimelineStart, jump)
267272
}

‎sentry-android-replay/src/main/java/io/sentry/android/replay/capture/BufferCaptureStrategy.kt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ constructor(
7171
}
7272

7373
override fun pause() {
74-
createCurrentSegment("pause", ::buffer)
74+
createCurrentSegment("pause") { segment, timeline -> buffer(segment, timeline) }
7575
super.pause()
7676
}
7777

@@ -192,7 +192,7 @@ constructor(
192192
}
193193

194194
override fun onConfigurationChanged(recorderConfig: ScreenshotRecorderConfig) {
195-
createCurrentSegment("configuration_changed", ::buffer)
195+
createCurrentSegment("configuration_changed") { segment, timeline -> buffer(segment, timeline) }
196196
super.onConfigurationChanged(recorderConfig)
197197
}
198198

@@ -315,7 +315,7 @@ constructor(
315315
)
316316
return
317317
}
318-
val request = SegmentRequest(::wholeBuffer)
318+
val request = SegmentRequest { wholeBuffer(it) }
319319
val replayId = currentReplayId
320320

321321
replayExecutor.submit(

0 commit comments

Comments
 (0)