fix(profiling): Accept dots in the JVM profiling traces dir path

JavaContinuousProfiler refused any traces directory whose path held one
of 26 characters, including ".", so a cache dir like /home/app/.sentry
or /opt/my.app logged "Disabling profiling". async-profiler only treats
"," (its argument separator) and "%" (file name patterns) specially, so
those are the only characters it still rejects.

The check also only stopped the first start: init() marked itself done
before validating and returned true from then on, so later starts went
ahead with the rejected options. It now remembers the result, as the
Android profiler does.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Author: runningcode

sentry-async-profiler/src/main/java/io/sentry/asyncprofiler/profiling/JavaContinuousProfiler.java

@@ -42,16 +42,15 @@
 public final class JavaContinuousProfiler
     implements IContinuousProfiler, RateLimiter.IRateLimitObserver {
   private static final long MAX_CHUNK_DURATION_MILLIS = 10000;
-  private final List<String> invalidFilenameChars =
-      Arrays.asList(
-          ".", ",", ":", ";", "|", "\\", "=", "%", "&", "[", "]", "(", ")", "<", ">", "{", "}", "!",
-          "*", "?", "~", "\"", "'", "$", "`", "^");
+  // async-profiler splits its arguments on "," and expands "%" patterns in the file name.
+  private final List<String> invalidFilenameChars = Arrays.asList(",", "%");
 
   private final @NotNull ILogger logger;
   private final @Nullable String profilingTracesDirPath;
   private final int profilingTracesHz;
   private final @NotNull ISentryExecutorService executorService;
   private boolean isInitialized = false;
+  private boolean hasValidOptions = false;
   private boolean isRunning = false;
   private @Nullable IScopes scopes;
   private @Nullable Future<?> stopFuture;
@@ -92,7 +91,7 @@ private void initializeProfiler() throws Exception {
 
   private boolean init() {
     if (isInitialized) {
-      return true;
+      return hasValidOptions;
     }
     isInitialized = true;
 
@@ -107,6 +106,7 @@ private boolean init() {
           profilingTracesHz);
       return false;
     }
+    hasValidOptions = true;
     return true;
   }
 

sentry-async-profiler/src/test/java/io/sentry/asyncprofiler/profiling/JavaContinuousProfilerTest.kt

@@ -421,6 +421,31 @@ class JavaContinuousProfilerTest {
       )
   }
 
+  @Test
+  fun `profiler starts when the traces dir path contains a dot`() {
+    val profiler = fixture.getSut {
+      it.profilingTracesDirPath = File("tmp", "sentry.traces").absolutePath
+    }
+    File(fixture.options.profilingTracesDirPath!!).mkdirs()
+
+    profiler.startProfiler(ProfileLifecycle.MANUAL, fixture.mockTracesSampler)
+    assertTrue(profiler.isRunning)
+    profiler.close(true)
+  }
+
+  @Test
+  fun `profiler stays disabled when the traces dir is created after its first start`() {
+    val tracesDir = File(fixture.options.profilingTracesDirPath!!)
+    tracesDir.deleteRecursively()
+    val profiler = fixture.getSut()
+    profiler.startProfiler(ProfileLifecycle.MANUAL, fixture.mockTracesSampler)
+    assertFalse(profiler.isRunning)
+
+    tracesDir.mkdirs()
+    profiler.startProfiler(ProfileLifecycle.MANUAL, fixture.mockTracesSampler)
+    assertFalse(profiler.isRunning)
+  }
+
   fun withMockScopes(closure: () -> Unit) =
     Mockito.mockStatic(Sentry::class.java).use {
       it.`when`<Any> { Sentry.getCurrentScopes() }.thenReturn(fixture.scopes)