Skip to content

Commit 7f94ff0

Browse files
adinauerclaude
andauthored
build(deps): Bump OpenTelemetry to 2.33.1 (#6602)
* build(deps): Bump OpenTelemetry to 2.33.1 Align the OpenTelemetry instrumentation and Java agent with SDK 1.67.0. Update tests for the SDK optimization that returns non-recording spans when no span processor is configured. Co-Authored-By: Claude <noreply@anthropic.com> * changelog * changelog * build(deps): Align OpenTelemetry semantic conventions Use the semantic convention versions tested with OpenTelemetry Java instrumentation 2.33.1. Co-Authored-By: Claude <noreply@anthropic.com> * docs(changelog): Clarify OpenTelemetry dependency bump List the semantic convention upgrades and explain how missing span processors affect outgoing Sentry trace headers. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent 013d0cc commit 7f94ff0

5 files changed

Lines changed: 55 additions & 21 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,16 @@
2525
- Nav3: Stop attributing errors and spans from an Activity or ViewPager2 page without a `SentryNavEffect` to the most recently visited Nav3 root ([#6483](https://github.com/getsentry/sentry-java/pull/6483))
2626
- Android: Count deep sleep in breadcrumb, screenshot and view hierarchy debounce windows, so the first low-memory or battery breadcrumb after a long Doze is no longer dropped ([#6590](https://github.com/getsentry/sentry-java/pull/6590))
2727

28+
### Dependencies
29+
30+
- Bump OpenTelemetry ([#6602](https://github.com/getsentry/sentry-java/pull/6602))
31+
- OpenTelemetry to 1.67.0 (was 1.63.0)
32+
- OpenTelemetry Instrumentation to 2.33.1 (was 2.29.0)
33+
- OpenTelemetry Instrumentation Alpha to 2.33.1-alpha (was 2.29.0-alpha)
34+
- OpenTelemetry Semantic Conventions to 1.44.0 (was 1.42.0)
35+
- OpenTelemetry Semantic Conventions Alpha to 1.44.0-alpha (was 1.42.0-alpha)
36+
- OpenTelemetry 1.67 creates no-op spans when no `SpanProcessor` is configured. If you construct the OpenTelemetry SDK manually while using `sentry-opentelemetry-otlp` classes directly, configure a span processor. Without one, Sentry cannot inspect outgoing request URLs and may inject `sentry-trace` and `baggage` headers into destinations excluded by `tracePropagationTargets`. Standard OTLP exporter, Sentry Java agent, and agentless setups already configure one.
37+
2838
## 8.64.0
2939

3040
### Breaking Changes

‎gradle/libs.versions.toml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ nopen = "1.0.1"
3030
# see https://developer.android.com/jetpack/androidx/releases/compose-kotlin
3131
okhttp = "5.5.1"
3232
openfeature = "1.18.2"
33-
otel = "1.63.0"
34-
otelAlpha = "1.63.0-alpha"
35-
otelInstrumentation = "2.29.0"
36-
otelInstrumentationAlpha = "2.29.0-alpha"
33+
otel = "1.67.0"
34+
otelAlpha = "1.67.0-alpha"
35+
otelInstrumentation = "2.33.1"
36+
otelInstrumentationAlpha = "2.33.1-alpha"
3737
# check https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/dependencyManagement/build.gradle.kts#L49 for release version above to find a compatible version
38-
otelSemanticConventions = "1.42.0"
39-
otelSemanticConventionsAlpha = "1.42.0-alpha"
38+
otelSemanticConventions = "1.44.0"
39+
otelSemanticConventionsAlpha = "1.44.0-alpha"
4040
retrofit = "3.0.0"
4141
room2 = "2.8.5"
4242
room3 = "3.0.0-rc01"

‎sentry-opentelemetry/sentry-opentelemetry-core/src/test/kotlin/SentrySamplerTest.kt‎

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ import io.opentelemetry.api.trace.TraceFlags
99
import io.opentelemetry.api.trace.TraceState
1010
import io.opentelemetry.context.Context
1111
import io.opentelemetry.sdk.trace.SdkTracerProvider
12+
import io.opentelemetry.sdk.trace.export.SimpleSpanProcessor
13+
import io.opentelemetry.sdk.trace.export.SpanExporter
1214
import io.opentelemetry.sdk.trace.samplers.Sampler
1315
import io.opentelemetry.sdk.trace.samplers.SamplingDecision
1416
import io.sentry.DataCategory
@@ -138,18 +140,24 @@ class SentrySamplerTest {
138140
verify(onDiscard).execute(DiscardReason.CALLBACK_ERROR, DataCategory.Span, 1)
139141
verifyNoMoreInteractions(onDiscard)
140142
val recordingSampler = mock<Sampler>(defaultAnswer = delegatesTo(sampler))
141-
SdkTracerProvider.builder().setSampler(recordingSampler).build().use { provider ->
142-
val openTelemetry =
143-
mock<OpenTelemetry>().also {
144-
whenever(it.tracerProvider).thenReturn(provider)
145-
}
146-
OtelSpanFactory(openTelemetry).createTransaction(context, scopes, TransactionOptions(), null)
147-
val attributes = argumentCaptor<Attributes>()
148-
verify(recordingSampler).shouldSample(any(), any(), any(), any(), attributes.capture(), any())
149-
val restored = OtelSamplingUtil.extractSamplingDecision(attributes.firstValue)!!
150-
assertThat(restored.sampled).isFalse()
151-
assertThat(restored.profileSampled).isFalse()
152-
}
143+
SdkTracerProvider.builder()
144+
.setSampler(recordingSampler)
145+
.addSpanProcessor(SimpleSpanProcessor.create(SpanExporter.composite()))
146+
.build()
147+
.use { provider ->
148+
val openTelemetry =
149+
mock<OpenTelemetry>().also {
150+
whenever(it.tracerProvider).thenReturn(provider)
151+
}
152+
OtelSpanFactory(openTelemetry)
153+
.createTransaction(context, scopes, TransactionOptions(), null)
154+
val attributes = argumentCaptor<Attributes>()
155+
verify(recordingSampler)
156+
.shouldSample(any(), any(), any(), any(), attributes.capture(), any())
157+
val restored = OtelSamplingUtil.extractSamplingDecision(attributes.firstValue)!!
158+
assertThat(restored.sampled).isFalse()
159+
assertThat(restored.profileSampled).isFalse()
160+
}
153161

154162
verifyNoMoreInteractions(onDiscard)
155163
}

‎sentry-opentelemetry/sentry-opentelemetry-otlp/src/test/kotlin/OtelSentryPropagatorTest.kt‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ import io.opentelemetry.context.Context
88
import io.opentelemetry.context.propagation.TextMapGetter
99
import io.opentelemetry.context.propagation.TextMapSetter
1010
import io.opentelemetry.sdk.trace.SdkTracerProvider
11+
import io.opentelemetry.sdk.trace.export.SimpleSpanProcessor
12+
import io.opentelemetry.sdk.trace.export.SpanExporter
1113
import io.sentry.Baggage
1214
import io.sentry.Sentry
1315
import kotlin.test.AfterTest
@@ -180,7 +182,10 @@ class OpenTelemetryOtlpPropagatorTest {
180182
}
181183
val propagator = OpenTelemetryOtlpPropagator()
182184
val carrier = mutableMapOf<String, String>()
183-
val tracerProvider = SdkTracerProvider.builder().build()
185+
val tracerProvider =
186+
SdkTracerProvider.builder()
187+
.addSpanProcessor(SimpleSpanProcessor.create(SpanExporter.composite()))
188+
.build()
184189
val otelSpan =
185190
tracerProvider
186191
.get("test")
@@ -220,7 +225,10 @@ class OpenTelemetryOtlpPropagatorTest {
220225
}
221226
val propagator = OpenTelemetryOtlpPropagator()
222227
val carrier = mutableMapOf<String, String>()
223-
val tracerProvider = SdkTracerProvider.builder().build()
228+
val tracerProvider =
229+
SdkTracerProvider.builder()
230+
.addSpanProcessor(SimpleSpanProcessor.create(SpanExporter.composite()))
231+
.build()
224232
val otelSpan =
225233
tracerProvider
226234
.get("test")

‎sentry-opentelemetry/sentry-opentelemetry-otlp/src/test/kotlin/OtlpEndToEndTest.kt‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ package io.sentry.opentelemetry.otlp
33
import com.google.common.truth.Truth.assertThat
44
import io.opentelemetry.sdk.OpenTelemetrySdk
55
import io.opentelemetry.sdk.trace.SdkTracerProvider
6+
import io.opentelemetry.sdk.trace.export.SimpleSpanProcessor
7+
import io.opentelemetry.sdk.trace.export.SpanExporter
68
import io.sentry.Sentry
79
import io.sentry.test.MockSentryServer
810
import io.sentry.test.event
@@ -20,7 +22,13 @@ import kotlin.test.Test
2022
class OtlpEndToEndTest {
2123
private val server = MockSentryServer()
2224
private val openTelemetry =
23-
OpenTelemetrySdk.builder().setTracerProvider(SdkTracerProvider.builder().build()).build()
25+
OpenTelemetrySdk.builder()
26+
.setTracerProvider(
27+
SdkTracerProvider.builder()
28+
.addSpanProcessor(SimpleSpanProcessor.create(SpanExporter.composite()))
29+
.build()
30+
)
31+
.build()
2432

2533
@AfterTest
2634
fun teardown() {

0 commit comments

Comments
 (0)