1313@ ApiStatus .Internal
1414public final class SentryStackTraceFactory {
1515
16- private static final int STACKTRACE_FRAME_LIMIT = 100 ;
16+ private static final int NEWEST_FRAMES_LIMIT = 200 ;
17+ private static final int OLDEST_FRAMES_LIMIT = 50 ;
1718 private final @ NotNull SentryOptions options ;
1819
1920 public SentryStackTraceFactory (final @ NotNull SentryOptions options ) {
@@ -32,45 +33,62 @@ public List<SentryStackFrame> getStackFrames(
3233 List <SentryStackFrame > sentryStackFrames = null ;
3334
3435 if (elements != null && elements .length > 0 ) {
35- sentryStackFrames = new ArrayList <>();
36- for (StackTraceElement item : elements ) {
37- if (item != null ) {
38-
39- // we don't want to add our own frames
40- final String className = item .getClassName ();
41- if (!includeSentryFrames
42- && (className .startsWith ("io.sentry." )
43- && !className .startsWith ("io.sentry.samples." )
44- && !className .startsWith ("io.sentry.mobile." ))) {
45- continue ;
46- }
36+ int frameCount = 0 ;
37+ for (final StackTraceElement item : elements ) {
38+ if (shouldIncludeFrame (item , includeSentryFrames )) {
39+ frameCount ++;
40+ }
41+ }
4742
48- final SentryStackFrame sentryStackFrame = new SentryStackFrame ();
49- // https://docs.sentry.io/development/sdk-dev/features/#in-app-frames
50- sentryStackFrame .setInApp (isInApp (className ));
51- sentryStackFrame .setModule (className );
52- sentryStackFrame .setFunction (item .getMethodName ());
53- sentryStackFrame .setFilename (item .getFileName ());
54- // Protocol doesn't accept negative line numbers.
55- // The runtime seem to use -2 as a way to signal a native method
56- if (item .getLineNumber () >= 0 ) {
57- sentryStackFrame .setLineno (item .getLineNumber ());
58- }
59- sentryStackFrame .setNative (item .isNativeMethod ());
60- sentryStackFrames .add (sentryStackFrame );
43+ sentryStackFrames =
44+ new ArrayList <>(Math .min (frameCount , NEWEST_FRAMES_LIMIT + OLDEST_FRAMES_LIMIT ));
45+ int frameIndex = 0 ;
46+ for (final StackTraceElement item : elements ) {
47+ if (!shouldIncludeFrame (item , includeSentryFrames )) {
48+ continue ;
49+ }
6150
62- // hard cap to not exceed payload size limit
63- if (sentryStackFrames .size () >= STACKTRACE_FRAME_LIMIT ) {
64- break ;
65- }
51+ if (frameIndex < NEWEST_FRAMES_LIMIT || frameIndex >= frameCount - OLDEST_FRAMES_LIMIT ) {
52+ sentryStackFrames .add (getSentryStackFrame (item ));
6653 }
54+ frameIndex ++;
6755 }
6856 Collections .reverse (sentryStackFrames );
6957 }
7058
7159 return sentryStackFrames ;
7260 }
7361
62+ private static boolean shouldIncludeFrame (
63+ final @ Nullable StackTraceElement item , final boolean includeSentryFrames ) {
64+ if (item == null ) {
65+ return false ;
66+ }
67+
68+ final String className = item .getClassName ();
69+ return includeSentryFrames
70+ || !className .startsWith ("io.sentry." )
71+ || className .startsWith ("io.sentry.samples." )
72+ || className .startsWith ("io.sentry.mobile." );
73+ }
74+
75+ private @ NotNull SentryStackFrame getSentryStackFrame (final @ NotNull StackTraceElement item ) {
76+ final SentryStackFrame sentryStackFrame = new SentryStackFrame ();
77+ final String className = item .getClassName ();
78+ // https://docs.sentry.io/development/sdk-dev/features/#in-app-frames
79+ sentryStackFrame .setInApp (isInApp (className ));
80+ sentryStackFrame .setModule (className );
81+ sentryStackFrame .setFunction (item .getMethodName ());
82+ sentryStackFrame .setFilename (item .getFileName ());
83+ // Protocol doesn't accept negative line numbers.
84+ // The runtime seem to use -2 as a way to signal a native method
85+ if (item .getLineNumber () >= 0 ) {
86+ sentryStackFrame .setLineno (item .getLineNumber ());
87+ }
88+ sentryStackFrame .setNative (item .isNativeMethod ());
89+ return sentryStackFrame ;
90+ }
91+
7492 /**
7593 * Provides the logic to decide whether a className is part of the includes or excludes list of
7694 * strings. The bias is towards includes, meaning once a className starts with a prefix in the
0 commit comments