Skip to content

Commit a0559d2

Browse files
committed
test(spring-boot): Remove the log4j2 Boot samples' system tests
The jakarta-log4j2 and 4-log4j2 samples' system tests were copies of the plain samples' tests, which now run in the modules' integrationTest suites. The only addition was a check that a logged error carries the Log4j integration. That's covered by SentryLog4j2AppenderAutoConfigurationTest, which checks the appender Spring Boot attaches, and by sentry-log4j2's own tests of what the appender sends. Both samples come off the system-test runner and the backend workflow. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 parent dc5d79e commit a0559d2

27 files changed

Lines changed: 0 additions & 1721 deletions

‎.github/workflows/system-tests-backend.yml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ jobs:
4040
- sample: "sentry-samples-spring-boot-webflux"
4141
agent: "false"
4242
agent-auto-init: "true"
43-
- sample: "sentry-samples-spring-boot-jakarta-log4j2"
44-
agent: "false"
45-
agent-auto-init: "true"
4643
- sample: "sentry-samples-spring-boot-jakarta-opentelemetry-noagent"
4744
agent: "false"
4845
agent-auto-init: "true"
@@ -64,9 +61,6 @@ jobs:
6461
- sample: "sentry-samples-jul"
6562
agent: "false"
6663
agent-auto-init: "true"
67-
- sample: "sentry-samples-spring-boot-4-log4j2"
68-
agent: "false"
69-
agent-auto-init: "true"
7064
- sample: "sentry-samples-spring-boot-4-webflux"
7165
agent: "false"
7266
agent-auto-init: "true"

‎sentry-samples/sentry-samples-spring-boot-4-log4j2/build.gradle.kts‎

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ plugins {
66
alias(libs.plugins.spring.dependency.management)
77
alias(libs.plugins.kotlin.jvm)
88
alias(libs.plugins.kotlin.spring)
9-
id("io.sentry.systemtest")
109
}
1110

1211
group = "io.sentry.sample.spring-boot-4-log4j2"
@@ -67,33 +66,4 @@ dependencies {
6766
// database query tracing
6867
implementation(projects.sentryJdbc)
6968
runtimeOnly(libs.hsqldb)
70-
71-
testImplementation(kotlin(Config.kotlinStdLib))
72-
testImplementation(projects.sentry)
73-
testImplementation(projects.sentrySystemTestSupport)
74-
testImplementation(libs.apollo3.kotlin)
75-
testImplementation(libs.kotlin.test.junit)
76-
testImplementation(libs.slf4j2.api)
77-
testImplementation(libs.springboot4.starter.test) {
78-
exclude(group = "org.junit.vintage", module = "junit-vintage-engine")
79-
}
80-
}
81-
82-
tasks.register<Test>("systemTest").configure {
83-
group = "verification"
84-
description = "Runs the System tests"
85-
86-
val test = project.extensions.getByType<SourceSetContainer>()["test"]
87-
testClassesDirs = test.output.classesDirs
88-
classpath = test.runtimeClasspath
89-
90-
maxParallelForks = 1
91-
92-
filter { includeTestsMatching("io.sentry.systemtest*") }
93-
}
94-
95-
tasks.named("test").configure {
96-
require(this is Test)
97-
98-
filter { excludeTestsMatching("io.sentry.systemtest.*") }
9969
}

‎sentry-samples/sentry-samples-spring-boot-4-log4j2/src/test/kotlin/io/sentry/DummyTest.kt‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎sentry-samples/sentry-samples-spring-boot-4-log4j2/src/test/kotlin/io/sentry/systemtest/CacheSystemTest.kt‎

Lines changed: 0 additions & 51 deletions
This file was deleted.

‎sentry-samples/sentry-samples-spring-boot-4-log4j2/src/test/kotlin/io/sentry/systemtest/DistributedTracingSystemTest.kt‎

Lines changed: 0 additions & 197 deletions
This file was deleted.

‎sentry-samples/sentry-samples-spring-boot-4-log4j2/src/test/kotlin/io/sentry/systemtest/GraphqlGreetingSystemTest.kt‎

Lines changed: 0 additions & 46 deletions
This file was deleted.

0 commit comments

Comments
 (0)