You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit a403884
Browse filesBrowse the repository at this point in the historyBrowse files
The cache's executor is a single daemon thread with allowCoreThreadTimeOut(true)
and a 30 second keep-alive, so it self-terminates once idle and never holds up
process exit. close() was switching off something that switches itself off.
Scopes.close() already leaves the timer executor running for this reason.
Dropping it removes the reason SentryOptions.resetHostnameCache() existed.
That method was only there because MainEventProcessor closed a cache the
options own, which a re-init with the same options object would then keep
handing out shut down. Nothing closes the cache now, so nothing has to undo it.
MainEventProcessor no longer implements Closeable, and no longer memoizes the
cache either: the options build it on first use, so the field and
ensureHostnameCache() were duplicating LazyEvaluator. Both removed methods are
on @ApiStatus.Internal types.
SentryClientTest's `when client is closed, hostname cache is closed` went with
them; it asserted isClosed() on a processor that had never resolved a hostname,
which returned true because the cache was still null.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0 commit comments