You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit a80d21b
Browse filesBrowse the repository at this point in the historyBrowse files
Fall back to the single-stack route when saved route arguments are missing and remove unused extractor-count bookkeeping from performance measurements.\n\nCo-Authored-By: Codex <noreply@openai.com>
Copy file name to clipboardExpand all lines: sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/navigation/nav3/Nav3Activity.kt
-4Lines changed: 0 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -296,8 +296,6 @@ private fun Nav3SampleApp(
296
296
controller = customTransactionController,
297
297
)
298
298
299
-
val nameExtractorCallsBefore = performanceState.nameExtractorCalls
300
-
val argumentsExtractorCallsBefore = performanceState.argumentsExtractorCalls
Copy file name to clipboardExpand all lines: sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/navigation/nav3/Nav3PerformanceControls.kt
-4Lines changed: 0 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -240,8 +240,6 @@ internal class Nav3PerformanceState(
240
240
241
241
funrecordSentryNavEffect(
242
242
durationNanos:Long,
243
-
nameExtractorCallsBefore:Int,
244
-
argumentsExtractorCallsBefore:Int,
245
243
extractorNanosBefore:Long,
246
244
processedCall:Boolean,
247
245
resolvedEntryCount:Int,
@@ -254,8 +252,6 @@ internal class Nav3PerformanceState(
254
252
return
255
253
}
256
254
257
-
val nameExtractorCallCount = nameExtractorCalls - nameExtractorCallsBefore
258
-
val argumentsExtractorCallCount = argumentsExtractorCalls - argumentsExtractorCallsBefore
259
255
sentryNavEffectAttempts++
260
256
val shouldCountAsProcessed = processedCall && pendingProcessedNavigationWork
Copy file name to clipboardExpand all lines: sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/navigation/nav3/Nav3Routes.kt
+14-7Lines changed: 14 additions & 7 deletions
Original file line number
Diff line number
Diff line change
@@ -110,16 +110,23 @@ private fun Bundle.toNav3Route(): Nav3Route {
110
110
"custom"->Nav3Route.Custom
111
111
"deep_link"->Nav3Route.DeepLink
112
112
"product_list"->Nav3Route.ProductList
113
-
"product_detail"->
113
+
"product_detail"-> {
114
+
val productId = getString("product_id") ?:returnNav3Route.SingleStack
115
+
val source = getString("source") ?:returnNav3Route.SingleStack
0 commit comments